RTL support when using Apache POI with openPdf#729
Open
nucleussoftwareopen wants to merge 1 commit into
Open
Conversation
kevinleturc
reviewed
Apr 27, 2026
Collaborator
kevinleturc
left a comment
kevinleturc
left a comment
There was a problem hiding this comment.
Could a test be added?
|
|
||
| // writing-mode | ||
| String writingMode = ele.getStyleWritingModeAttribute(); | ||
| if ( StringUtils.isNotEmpty( writingMode ) ){ |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ( StringUtils.isNotEmpty( writingMode ) ){ | |
| if ( StringUtils.isNotEmpty( writingMode ) ) | |
| { |
|
|
||
| // writing-mode | ||
| String writingMode = ele.getStyleWritingModeAttribute(); | ||
| if ( StringUtils.isNotEmpty( writingMode ) ){ |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ( StringUtils.isNotEmpty( writingMode ) ){ | |
| if ( StringUtils.isNotEmpty( writingMode ) ) | |
| { |
Collaborator
There was a problem hiding this comment.
Could you add a Copyright header like other files and a new line at the end of the file?
| @@ -0,0 +1,25 @@ | |||
| package fr.opensagres.poi.xwpf.converter.core.styles.table; | |||
Collaborator
There was a problem hiding this comment.
Could you add a Copyright header like other files and a new line at the end of the file?
Comment on lines
+38
to
+39
| import fr.opensagres.poi.xwpf.converter.core.styles.paragraph.ParagraphRunDirectionProvider; | ||
| import fr.opensagres.poi.xwpf.converter.core.styles.table.TableRunDirectionValueProvider; |
Collaborator
There was a problem hiding this comment.
Could the import be moved next to other fr.opensagres and ordered?
| } | ||
|
|
||
| /*enabling bidirectional support*/ | ||
| public CTOnOff getParagraphRunDirection(XWPFParagraph docxParagraph) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| public CTOnOff getParagraphRunDirection(XWPFParagraph docxParagraph) { | |
| public CTOnOff getParagraphRunDirection( XWPFParagraph docxParagraph ) | |
| { |
| } | ||
|
|
||
| /*enabling bidirectional support*/ | ||
| public CTOnOff getTableRunDirection(XWPFTable table ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| public CTOnOff getTableRunDirection(XWPFTable table ) | |
| public CTOnOff getTableRunDirection( XWPFTable table ) |
| import java.util.Map; | ||
| import java.util.logging.Logger; | ||
|
|
||
| import com.lowagie.text.pdf.PdfWriter; |
Collaborator
There was a problem hiding this comment.
Could it be moved next to other com.lowagie and ordered?
Comment on lines
+199
to
+205
| public String getWritingMode() { | ||
| return writingMode; | ||
| } | ||
|
|
||
| public void setWritingMode(String writingMode) { | ||
| this.writingMode = writingMode; | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| public String getWritingMode() { | |
| return writingMode; | |
| } | |
| public void setWritingMode(String writingMode) { | |
| this.writingMode = writingMode; | |
| } | |
| public String getWritingMode() | |
| { | |
| return writingMode; | |
| } | |
| public void setWritingMode( String writingMode ) | |
| { | |
| this.writingMode = writingMode; | |
| } |
Comment on lines
+225
to
+231
| // Support for writing mode i.e. LTR OR RTL | ||
| String writingMode = tableProperties.getWritingMode(); | ||
| if ( writingMode != null && writingMode.equals("rl-tb")) | ||
| { | ||
| // RTL | ||
| super.setRunDirection(PdfWriter.RUN_DIRECTION_RTL); | ||
| } |
Collaborator
There was a problem hiding this comment.
There's no else block compared to StylableParagraph, should it be added there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.