Adding BWC test for remote publication enabled cluster #20221
Conversation
Signed-off-by: Harsh Garg <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20221 +/- ##
============================================
+ Coverage 72.82% 73.19% +0.36%
- Complexity 71315 71730 +415
============================================
Files 5795 5795
Lines 328297 328302 +5
Branches 47282 47283 +1
============================================
+ Hits 239089 240298 +1209
+ Misses 69893 68696 -1197
+ Partials 19315 19308 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rajiv-kv
left a comment
rajiv-kv
left a comment
There was a problem hiding this comment.
Can you include the build logs (from your local runs / remote jenkins) where the additional tests are able to run successfully with remote publication enabled ?
| if (testFilter == 'exclude') { | ||
| exclude '**/RemotePublicationClusterStateIT.class' | ||
| } else if (testFilter == 'include') { | ||
| include '**/RemotePublicationClusterStateIT.class' | ||
| } |
There was a problem hiding this comment.
Can we run this test in disabled mode also ?
| private static final String componentTemplateName = "test_component_template"; | ||
|
|
||
| public void testUpgradeWithRemotePublicationEnabled() throws Exception { | ||
| if (CLUSTER_TYPE == ClusterType.OLD) { |
There was a problem hiding this comment.
what will be different b/w old and upgraded cluster ?
| include '**/RemotePublicationClusterStateIT.class' | ||
| } | ||
|
|
||
| extraConfig.delegate = delegate |
There was a problem hiding this comment.
why is this required ? Does the RHS delegate refer to the configureTask method ?
2 participants
Description
RemotePublication feature was missing BackWardCompatibility rolling upgrade integration tests which was leading to unintended incompatibilities between versions.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.