Skip to content

fix connector executor: restore context #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

fix connector executor: restore context #4428

wants to merge 5 commits into from

Conversation

@ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Nov 18, 2025 •
edited
Loading

Description

Restore context after running connector executor.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn added the v3.4.0 Issues targeting release v3.4.0 label Nov 18, 2025
@ylwu-amzn ylwu-amzn force-pushed the agent_mem_integ_pr branch 2 times, most recently from a710f11 to cbd6e56 Compare November 18, 2025 06:32
dhrubo-os
dhrubo-os previously approved these changes Nov 18, 2025
View reviewed changes
pyek-bot
pyek-bot previously approved these changes Nov 18, 2025
View reviewed changes
ylwu-amzn and others added 2 commits November 18, 2025 11:48
@ylwu-amzn
Add support for custom named connector actions; add PUT/DELETE action (…
285b6e2 
…opensearch-project#4430)

* Add support for custom named connector actions; add PUT/DELETE action

Signed-off-by: Yaliang Wu <[email protected]>

* add more comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
@mingshl @Zhangxunmt
[3.4 Feature Branch] Introduce hook and context management to OpenSea…
f4ac35c 
…rch Agents (opensearch-project#4432)

* add hooks in ml-commons (opensearch-project#4326)

Signed-off-by: Xun Zhang <[email protected]>

* initiate context management api with hook implementation (opensearch-project#4345)

* initiate context management api with hook implementation

Signed-off-by: Mingshi Liu <[email protected]>

* apply spotless

Signed-off-by: Mingshi Liu <[email protected]>

---------

Signed-off-by: Mingshi Liu <[email protected]>

* Add Context Manager to PER (opensearch-project#4379)

* add pre_llm hook to per agent

Signed-off-by: Mingshi Liu <[email protected]>

change context management passing from query parameters to payload

Signed-off-by: Mingshi Liu <[email protected]>

pass hook registery into PER

Signed-off-by: Mingshi Liu <[email protected]>

apply spotless

Signed-off-by: Mingshi Liu <[email protected]>

initiate context management api with hook implementation

Signed-off-by: Mingshi Liu <[email protected]>

* add comment

Signed-off-by: Mingshi Liu <[email protected]>

* format

Signed-off-by: Mingshi Liu <[email protected]>

* add validation

Signed-off-by: Mingshi Liu <[email protected]>

---------

Signed-off-by: Mingshi Liu <[email protected]>

* add inner create context management to agent register api

Signed-off-by: Mingshi Liu <[email protected]>

* add code coverage

Signed-off-by: Mingshi Liu <[email protected]>

* allow context management hook register in during agent execute

Signed-off-by: Mingshi Liu <[email protected]>

* add code coverage

Signed-off-by: Mingshi Liu <[email protected]>

* add more code coverage

Signed-off-by: Mingshi Liu <[email protected]>

* add validation check

Signed-off-by: Mingshi Liu <[email protected]>

* adapt to inplace update for context

Signed-off-by: Mingshi Liu <[email protected]>

* Allow context management inline create in register agent without storing in index (opensearch-project#4403)

* allow inline create context management without storing in agent register

Signed-off-by: Mingshi Liu <[email protected]>

* make ML_COMMONS_MULTI_TENANCY_ENABLED default is false

Signed-off-by: Mingshi Liu <[email protected]>

---------

Signed-off-by: Mingshi Liu <[email protected]>

* Update the POST_TOOL hook emit saving to agentic memory (opensearch-project#4408)

* Fix POST_TOOL hook interaction updates and add tenant ID support
Signed-off-by: Mingshi Liu <[email protected]>

- Fix POST_TOOL hook to return full ContextManagerContext like PRE_LLM hook
- Update MLChatAgentRunner to properly handle interaction updates from POST_TOOL hook
- Ensure interactions list and tmpParameters.INTERACTIONS stay synchronized
- Add tenant ID support to MLPredictionTaskRequest in ModelGuardrail and SummarizationManager

Signed-off-by: Mingshi Liu <[email protected]>

* fix error message escaping

Signed-off-by: Mingshi Liu <[email protected]>

* consolicate post_hook logic

Signed-off-by: Mingshi Liu <[email protected]>

---------

Signed-off-by: Mingshi Liu <[email protected]>

* bump supported version to 3.4

Signed-off-by: Mingshi Liu <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]>
Co-authored-by: Xun Zhang <[email protected]>
@ylwu-amzn ylwu-amzn dismissed stale reviews from pyek-bot and dhrubo-os via fbe3ca4 November 18, 2025 21:45
@ylwu-amzn ylwu-amzn closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhrubo-os dhrubo-os dhrubo-os left review comments

@pyek-bot pyek-bot pyek-bot left review comments

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman sam-herman is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

+1 more reviewer

@rithin-pullela-aws rithin-pullela-aws rithin-pullela-aws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 3.3 v3.4.0 Issues targeting release v3.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ylwu-amzn @dhrubo-os @pyek-bot @rithin-pullela-aws @mingshl