-
Notifications
You must be signed in to change notification settings - Fork 3
AI-powered EgressIP performance analysis #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
AI-powered EgressIP performance analysis #3
Conversation
SachinNinganure
commented
Nov 12, 2025
- Integration with existing CORNET-6498 tests
- Comprehensive monitoring and metrics
- Production-ready implementation with full documentation
|
@liqcui Please review |
|
/hold |
|
Testing is still in progress! also I think we can integrate coderabbit or my ai-helper pr for the initial checks @liqcui @qiliRedHat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-org your mcp tool folder, follow the same style of folder structure. we usually create config in the folder https://github.com/openshift-eng/ocp-performance-analyzer-mcp/tree/main/config. suggest the name config-egress.yml if it's not PromQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the tools into https://github.com/openshift-eng/ocp-performance-analyzer-mcp/tree/main/tools and create a separated folder tools/egressip, the same with other tool code.
|
Hi @liqcui please check the changes! |
|
@SachinNinganure Please unified all your folder to egressip. and file name start with egressip_xxx, just avoid to confuse with egressfirewall in the future. follow the same naming conventions |
| if __name__ == "__main__": | ||
| # Start the MCP server | ||
| logger.info("Starting EgressIP Performance Analyzer MCP Server") | ||
| mcp.run(transport="stdio") No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan connect to your mcp server via claude desktop via stdio?