Skip to content

Conversation

@SachinNinganure
Copy link

   - Integration with existing CORNET-6498 tests
   - Comprehensive monitoring and metrics
   - Production-ready implementation with full documentation
   - https://issues.redhat.com/browse/CORENET-6498

       - Integration with existing CORNET-6498 tests
       - Comprehensive monitoring and metrics
       - Production-ready implementation with full documentation
@SachinNinganure
Copy link
Author

@liqcui Please review

@SachinNinganure
Copy link
Author

/hold

@SachinNinganure
Copy link
Author

Testing is still in progress!

also I think we can integrate coderabbit or my ai-helper pr for the initial checks @liqcui @qiliRedHat

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-org your mcp tool folder, follow the same style of folder structure. we usually create config in the folder https://github.com/openshift-eng/ocp-performance-analyzer-mcp/tree/main/config. suggest the name config-egress.yml if it's not PromQL.

Copy link
Contributor

@liqcui liqcui Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the tools into https://github.com/openshift-eng/ocp-performance-analyzer-mcp/tree/main/tools and create a separated folder tools/egressip, the same with other tool code.

@SachinNinganure
Copy link
Author

Hi @liqcui please check the changes!

@liqcui
Copy link
Contributor

liqcui commented Nov 13, 2025

@SachinNinganure Please unified all your folder to egressip. and file name start with egressip_xxx, just avoid to confuse with egressfirewall in the future. follow the same naming conventions

if __name__ == "__main__":
# Start the MCP server
logger.info("Starting EgressIP Performance Analyzer MCP Server")
mcp.run(transport="stdio") No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan connect to your mcp server via claude desktop via stdio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants