OCPBUGS-74513: OCPBUGS-74519: Remove MachineConfigNodes and PinnedImages feature gates

[isabella-janssen]

This removes the MachineConfigNodes and PinnedImages feature gates and should merge after openshift/machine-config-operator#5609.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-74513, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This removes the MachineConfigNodes and PinnedImages feature gates and should merge after openshift/machine-config-operator#5609.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 01503617-be38-4409-b7dc-b590b8e79434

📥 Commits

Reviewing files that changed from the base of the PR and between 1d84ab4 and 7e5f270.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (9)

• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

📝 Walkthrough

Walkthrough

This change removes two feature gates from the codebase: FeatureGateMachineConfigNodes and FeatureGatePinnedImages. The removal includes deletion of their definitions in the features.go file, rows in the features.md documentation table, and entries from enabled/disabled lists across eight feature gate configuration YAML files covering both Hypershift and SelfManagedHA deployment modes with different preview levels (Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade configurations).

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removal of two feature gates (MachineConfigNodes and PinnedImages), which matches the changeset across all modified files.
Description check	✅ Passed	The description relates to the changeset by confirming the removal of the two feature gates and noting a dependency on another pull request, providing meaningful context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	The PR contains no test files and does not modify existing test files; changes are limited to feature gate configuration files.
Test Structure And Quality	✅ Passed	PR contains only non-test files (documentation, source code, and YAML configs); no Ginkgo test code requiring review.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6aa05d40-0c44-11f1-9ce4-4d5ce96c4ea8-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/843dfb40-0c44-11f1-9e48-755722ba80a8-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4e394a80-0cfe-11f1-9008-fbd59384bacd-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/524f9610-0cfe-11f1-8b6a-9e13349dc0d7-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5fc92400-0cfe-11f1-9bf2-4de395b04ad1-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5da83fd0-0cfe-11f1-8b6b-9146d3917b7a-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/633fd430-0cfe-11f1-96e2-6f48c960f3ec-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b4b40c0-0dbf-11f1-8257-094951812dc9-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7da906e0-0dbf-11f1-8e35-60e130204d6c-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/804c8890-0dbf-11f1-95a3-c5ba819bee74-0

[JoelSpeed]

/lgtm

Changes here are good when you're ready for this to go

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview	7e5f270	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift	7e5f270	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview-1of2	7e5f270	link	true	/test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-serial-1of2	7e5f270	link	true	/test e2e-aws-serial-1of2
ci/prow/e2e-azure	7e5f270	link	true	/test e2e-azure
ci/prow/e2e-aws-serial-2of2	7e5f270	link	true	/test e2e-aws-serial-2of2
ci/prow/e2e-aws-ovn-hypershift-conformance	7e5f270	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-gcp	7e5f270	link	true	/test e2e-gcp
ci/prow/e2e-aws-serial-techpreview-2of2	7e5f270	link	true	/test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-ovn	7e5f270	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.