CORS-4348: feature gate for EU Sovereign Cloud support#2740
CORS-4348: feature gate for EU Sovereign Cloud support#2740tthvo wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@tthvo: This pull request references CORS-4348 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @tthvo! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthroughThis pull request adds a new feature gate, AWSEuropeanSovereignCloudInstall: documented in features.md, declared and exported in features/features.go, and added to multiple FeatureGate payload manifests. The gate is enabled for DevPreviewNoUpgrade and TechPreviewNoUpgrade on Hypershift and SelfManagedHA profiles and appears as disabled in Default and OKD payload variants where applicable. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
Review Summary by QodoAdd feature gate for AWS European Sovereign Cloud installation
WalkthroughsDescription• Add feature gate for AWS European Sovereign Cloud installation support • Enable feature in DevPreview and TechPreview release channels • Update all 8 feature gate manifest files with new gate configuration • Document feature in features.md reference table Diagramflowchart LR
A["Feature Gate Definition"] -->|"Configure"| B["AWSEuropeanSovereignCloudInstall"]
B -->|"Enable in"| C["DevPreview & TechPreview"]
B -->|"Disable in"| D["Default & OKD"]
C -->|"Update"| E["8 Manifest Files"]
E -->|"Document in"| F["features.md"]
File Changes1. features/features.go
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
|
/cc @patrickdillon |
|
/lgtm /hold the EP should be merged first |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
New changes are detected. LGTM label has been removed. |
|
/hold cancel The enhancement is merged 👍 |
This PR added the feature gate for supporting EU Sovereign Cloud regions. See https://aws.amazon.com/compliance/europe-digital-sovereignty/