OCPBUGS-78766: [4.16] PPC: filter out namespaces dir by shajmakh · Pull Request #1466 · openshift/cluster-node-tuning-operator

shajmakh · 2026-02-05T09:37:58Z

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

The consts are not used anywhere else so make them private. (cherry picked from commit 0deb9c6) Signed-off-by: Shereen Haj <shajmakh@redhat.com>

The previous code fails to run PPC when there is a namespace that has a suffix `nodes`. ensure filtering the namespace directory to allow PPC to work when such namespaces exist. Signed-off-by: Shereen Haj <shajmakh@redhat.com> (cherry picked from commit e934592)

shajmakh · 2026-02-05T09:40:05Z

/hold
for 4.17 to be merged first

openshift-ci · 2026-02-05T09:42:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shajmakh · 2026-03-12T13:10:18Z

/unhold

shajmakh · 2026-03-12T13:10:33Z

/retest

openshift-ci-robot · 2026-03-18T07:47:01Z

@shajmakh: This pull request references Jira Issue OCPBUGS-78766, which is invalid:

expected dependent Jira Issue OCPBUGS-78214 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-18T07:47:06Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b084c21c-87fa-4256-94ea-f6666da024e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

shajmakh · 2026-03-18T07:47:08Z

/jira refresh

openshift-ci-robot · 2026-03-18T07:47:14Z

@shajmakh: This pull request references Jira Issue OCPBUGS-78766, which is invalid:

expected dependent Jira Issue OCPBUGS-78214 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shajmakh · 2026-03-18T08:49:36Z

/jira refresh
/retest

openshift-ci-robot · 2026-03-18T08:49:42Z

@shajmakh: This pull request references Jira Issue OCPBUGS-78766, which is invalid:

expected dependent Jira Issue OCPBUGS-78214 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shajmakh · 2026-03-18T10:13:28Z

/jira refresh

openshift-ci-robot · 2026-03-18T10:13:36Z

@shajmakh: This pull request references Jira Issue OCPBUGS-78766, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-78214 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-78214 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (oblau@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

oblau · 2026-03-22T07:56:13Z

/retest

openshift-ci · 2026-03-22T09:45:49Z

@shajmakh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	`6f2d3a0`	link	true	`/test okd-scos-images`
ci/prow/e2e-hypershift	`6f2d3a0`	link	true	`/test e2e-hypershift`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

shajmakh added 2 commits February 5, 2026 11:37

PPC: pkg: public consts to private

d09d26f

The consts are not used anywhere else so make them private. (cherry picked from commit 0deb9c6) Signed-off-by: Shereen Haj <shajmakh@redhat.com>

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2026

openshift-ci bot requested review from MarSik and swatisehgal February 5, 2026 09:41

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2026

shajmakh changed the title ~~[4.16] PPC: filter out namespaces dir~~ OCPBUGS-78766[4.16] PPC: filter out namespaces dir Mar 18, 2026

shajmakh changed the title ~~OCPBUGS-78766[4.16] PPC: filter out namespaces dir~~ OCPBUGS-78766: [4.16] PPC: filter out namespaces dir Mar 18, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2026

Conversation

shajmakh commented Feb 5, 2026

Uh oh!

shajmakh commented Feb 5, 2026

Uh oh!

openshift-ci bot commented Feb 5, 2026

Uh oh!

shajmakh commented Mar 12, 2026

Uh oh!

shajmakh commented Mar 12, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

shajmakh commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

shajmakh commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

shajmakh commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

oblau commented Mar 22, 2026

Uh oh!

openshift-ci bot commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 18, 2026 •

edited

Loading