WIP: Add OKD featureset enhancement #1899
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jatinsu
force-pushed
the
OKD-featuregates
branch
from
9a16308 to
a81a730
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
2 times, most recently
from
075812e to
a0218a1
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
from
a0218a1 to
8808148
Compare
enhancements/okd/okd-featureset.md
Outdated
| - Resource consumption impact should be minimal as the feature set itself only controls which features are enabled, not the features themselves | ||
| - Individual features enabled by the OKD feature set may have their own resource implications | ||
|
|
||
| **MicroShift:** |
There was a problem hiding this comment.
OKD featureset shouldn't affect microshift right?
There was a problem hiding this comment.
i don't think so, would be good to check with someone in the Microshift team
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Prashanth684
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
enhancements/okd/okd-featureset.md
Outdated
| - Resource consumption impact should be minimal as the feature set itself only controls which features are enabled, not the features themselves | ||
| - Individual features enabled by the OKD feature set may have their own resource implications | ||
|
|
||
| **MicroShift:** |
There was a problem hiding this comment.
i don't think so, would be good to check with someone in the Microshift team
jatinsu
force-pushed
the
OKD-featuregates
branch
from
e35a6c7 to
5f9509a
Compare
|
@jatinsu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ## Summary | ||
|
|
||
| This enhancement introduces a new "OKD" feature set in the OpenShift API that will be enabled by default on all OKD clusters. This feature set allows OKD clusters to enable select TechPreview features in addition to all features in the Default feature set while maintaining upgrade capability. This feature set will replace the Default feature set for OKD clusters. | ||
|
|
There was a problem hiding this comment.
in the summary and in the motivation we should mention that one of the main drivers is to enable features which have stable APIs early on OKD to not only provide these features to the community but also as a signal driver for OCP (with the community trying out upgrades, adopting features and our own nightly jobs testing upgrades and e2es)
|
|
||
| #### Scenario 1: Installing a new OKD cluster | ||
| 1. OKD cluster administrator initiates installation using OKD-built `openshift-install` | ||
| 2. CVO detects OKD build via build metadata |
There was a problem hiding this comment.
might want to be clearer what "build metadata" means here - maybe reword it to say - "if it has been built for OKD"
There was a problem hiding this comment.
we also need to mention that a cluster which has been installed with an older version of OKD which has a "Default" featureset will be automatically migrated to OKD by the CVO as well.
2 participants
This PR is to create an enhancement for the OKD featureset.
For more context: openshift/api#2451