Proposal to add custom must-gather image option in MusTtGather Spec. #1906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an enhancement proposal to support the use of custom must-gather images with the must-gather-operator. This feature allows cluster administrators to define an allowlist of trusted images that can be used for diagnostic data collection, providing a secure and flexible way to gather specialized information.
Summary:
The proposal introduces two main API changes:
A new
MustGatherImage CRD: This cluster-scoped resource acts as an allowlist for custom must-gather images. Cluster administrators can manage this resource to control which images are permitted to run in the cluster.An update to the
MustGather CRD: The MustGather CRD is extended with an optional mustGatherImage field. When creating a MustGather resource, users can specify an image from the allowlist to be used for the data collection job.The must-gather-operator's logic is updated to validate the mustGatherImage against the MustGatherImage allowlist. If the image is valid, the operator will use it to run the must-gather job. If the image is not in the allowlist, or if the allowlist is not configured, the MustGather resource's status will be updated with an error. If no custom image is specified, the operator will use the default must-gather image, ensuring backward compatibility.
User-Facing Changes:
Cluster administrators can now create and manage a
MustGatherImageresource to control the use of custom must-gather images.Users can specify a custom must-gather image in the
MustGather CR, provided it is in the allowlist.JIRA tracker:
https://issues.redhat.com/browse/MG-155