Skip to content

Conversation

@shivprakashmuley
Copy link
Contributor

@shivprakashmuley shivprakashmuley commented Dec 11, 2025

This PR introduces an enhancement proposal to support the use of custom must-gather images with the must-gather-operator. This feature allows cluster administrators to define an allowlist of trusted images that can be used for diagnostic data collection, providing a secure and flexible way to gather specialized information.

Summary:

The proposal introduces two main API changes:
A new MustGatherImage CRD: This cluster-scoped resource acts as an allowlist for custom must-gather images. Cluster administrators can manage this resource to control which images are permitted to run in the cluster.
An update to the MustGather CRD: The MustGather CRD is extended with an optional mustGatherImage field. When creating a MustGather resource, users can specify an image from the allowlist to be used for the data collection job.
The must-gather-operator's logic is updated to validate the mustGatherImage against the MustGatherImage allowlist. If the image is valid, the operator will use it to run the must-gather job. If the image is not in the allowlist, or if the allowlist is not configured, the MustGather resource's status will be updated with an error. If no custom image is specified, the operator will use the default must-gather image, ensuring backward compatibility.

User-Facing Changes:

Cluster administrators can now create and manage a MustGatherImage resource to control the use of custom must-gather images.
Users can specify a custom must-gather image in the MustGather CR, provided it is in the allowlist.

JIRA tracker:
https://issues.redhat.com/browse/MG-155

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign suleymanakbas91 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@shivprakashmuley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant