bp update

[ritmun]

contains updates to e2e convention

SDCICD-1785: enhanced slack notifications and removal of secrets as env vars

Summary by CodeRabbit

• New Features

  • Added Slack notification integration for test alerts with customizable channel configuration

• Infrastructure & Configuration Updates

  • Transitioned credential management from inline parameters to secure secret volume mounts
  • Introduced TEST_SUITES_YAML environment variable for centralized test suite specification
  • Enhanced test execution with log analysis support and improved secret path handling

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2b0dfeed-da27-47ad-9558-ec55f1a9e8ad

📥 Commits

Reviewing files that changed from the base of the PR and between 329b941 and f9ce2be.

⛔ Files ignored due to path filters (3)

• boilerplate/_data/backing-image-tag is excluded by !boilerplate/**
• boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
• boilerplate/openshift/golang-osd-e2e/e2e-template.yml is excluded by !boilerplate/**

📒 Files selected for processing (1)

• test/e2e/e2e-template.yml

---

Walkthrough

The CI/CD template shifts credential management from direct environment variable parameterization to secret-backed volumes. OCM and cloud provider credentials are removed as explicit parameters, replaced with Slack notification controls and a new TEST_SUITES_YAML payload. Pod spec configuration is extended with secret mounts and container arguments updated to reference external secret locations.

Changes

Cohort / File(s)

Summary

E2E Test Template Configuration test/e2e/e2e-template.yml

Removed direct parameterization of OCM credentials (OCM_CLIENT_ID, OCM_CLIENT_SECRET), AWS keys, GCP credentials, and PagerDuty routing key. Added optional Slack controls (SLACK_NOTIFY, SLACK_CHANNEL). Introduced TEST_SUITES_YAML environment payload. Extended pod spec with secret-backed volumes and mounts for external credentials. Updated container args to enable log analysis and point to secret mount paths via --secret-locations flag.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Ginkgo test files violate single responsibility, lack consistent SpecTimeout declarations, have inconsistent assertion messages, test multiple scenarios per test block, and lack explicit timeout contexts for cluster operations.	Refactor tests into focused single-responsibility tests, add explicit SpecTimeout to all tests, add meaningful failure messages to all assertions, apply explicit context.WithTimeout() to operations, and use BeforeEach/AfterEach blocks to separate concerns.
Title check	❓ Inconclusive	The title 'bp update' is vague and does not clearly describe the main changes. While 'bp' may refer to a branch name, the title fails to convey the specific nature of the modifications (e.g., template parameter changes, secret management updates, or Slack notification enhancements).	Use a more descriptive title that captures the primary change, such as 'Update e2e template to use secret volumes and Slack notifications' or 'Refactor e2e template credentials management and add Slack controls'.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the newly added test/e2e/validation_webhook_tests.go file are stable and deterministic with descriptive static strings.
Microshift Test Compatibility	✅ Passed	This PR only modifies test/e2e/e2e-template.yml, a YAML OpenShift CI configuration file, without adding any new Ginkgo e2e tests or Go test code.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are introduced in this PR; only infrastructure template configuration is modified.
Topology-Aware Scheduling Compatibility	✅ Passed	The modified e2e-template.yml contains no topology-unaware scheduling constraints that would break on SNO, Two-Node, or HyperShift topologies.
Ote Binary Stdout Contract	✅ Passed	The PR modifies only test/e2e/e2e-template.yml, a YAML template file containing Kubernetes Job specifications with no Go process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Pull request contains only infrastructure configuration changes to test/e2e/e2e-template.yml with no new Ginkgo test definitions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@ritmun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[feichashao]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, ritmun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [feichashao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment