Skip to content

fix: reduce the log for allowed authorization#496

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
bmeng:crd-webhook
Apr 28, 2026
Merged

fix: reduce the log for allowed authorization#496
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
bmeng:crd-webhook

Conversation

@bmeng
Copy link
Copy Markdown
Contributor

@bmeng bmeng commented Apr 28, 2026

Currently, the "Allowing access" logs is flooding the pod log

Summary by CodeRabbit

Release Notes

  • Chores
    • Reduced log verbosity by removing informational entries for non-protected CustomResourceDefinition operations. Authorization behavior remains unchanged.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@bmeng has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 23 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5a956e96-e45c-4ee8-9107-492205953571

📥 Commits

Reviewing files that changed from the base of the PR and between 0896272 and f192cba.

📒 Files selected for processing (4)
  • pkg/webhooks/customresourcedefinitions/customresourcedefinitions.go
  • pkg/webhooks/networkpolicies/networkpolicies.go
  • pkg/webhooks/prometheusrule/prometheusrule.go
  • pkg/webhooks/techpreviewnoupgrade/techpreviewnoupgrade.go

Walkthrough

A single informational log entry has been removed from the CustomResourceDefinitions webhook. The log was previously emitted when allowing requests for non-protected operations. Admission authorization behavior and response construction remain unchanged.

Changes

Cohort / File(s) Summary
Logging Cleanup
pkg/webhooks/customresourcedefinitions/customresourcedefinitions.go
Removed informational log statement for non-protected CustomResourceDefinition operations; no behavioral changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning PR adds 652 lines of Ginkgo e2e tests with 27 test cases that make multi-node cluster assumptions without SNO protection mechanisms. Add [Skipped:SingleReplicaTopology] labels or wrap tests with infrastructure topology checks using exutil.IsSingleNode() to ensure SNO compatibility.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: reduce the log for allowed authorization' accurately describes the main change: removing an informational log entry for allowed CustomResourceDefinition operations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only implementation file removing a log statement; associated tests use standard Go testing without Ginkgo framework, so stable test name check is not applicable.
Test Structure And Quality ✅ Passed This custom check for Ginkgo test code quality is not applicable to the current PR. The pull request only modifies production code in pkg/webhooks/customresourcedefinitions/customresourcedefinitions.go (removing a single log line) and does not modify any test files. Additionally, the repository uses the standard Go testing framework (testing.T) for all unit tests rather than Ginkgo. Since no Ginkgo tests exist in the codebase and no test code was modified in this PR, the Ginkgo-specific test quality requirements cannot be assessed.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. The change only removes a log statement from a webhook implementation file, so MicroShift compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only removes a log statement from a webhook handler file with no impact on scheduling behavior or deployment manifests.
Ote Binary Stdout Contract ✅ Passed This PR modifies a webhook component in pkg/webhooks/customresourcedefinitions/, which is not an OTE binary subject to the Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The PR modifies only a webhook implementation file, not test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@xiaoyu74
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

@bmeng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 36ee01a into openshift:master Apr 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants