Bump the kubernetes group across 1 directory with 5 updates#498
Bump the kubernetes group across 1 directory with 5 updates#498dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughBumps Go toolchain to 1.26.0 and updates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 7/10 reviews remaining, refill in 16 minutes and 55 seconds. Comment |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 19-22: The Kubernetes client bump to v0.36.0 may introduce
breaking changes; search and update webhook validation code (e.g., any
ValidateAdmissionReview/ValidatePodSpec/ValidateDeploymentSpec handlers and
related manifest validators) to (1) remove or explicitly reject gitRepo volume
references in Pod/Deployment specs and add migration guidance, (2) stop
enforcing or assuming Service.spec.externalIPs exists in validation logic and
handle its absence gracefully, and (3) update monitoring/alerting and any metric
names referenced in code/config from volume_operation_total_errors to
volume_operation_errors_total; also run tests against v1.36 API types to ensure
type/signature compatibility after the go.mod bump.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 33c03c0a-375b-485b-a9de-ad44fab095be
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| k8s.io/api v0.36.0 | ||
| k8s.io/apiextensions-apiserver v0.36.0 | ||
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/client-go v0.36.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Kubernetes 1.36.0 release notes breaking changes deprecations
💡 Result:
Kubernetes v1.36.0 breaking changes / deprecations (release notes) 1) gitRepo volume driver permanently disabled (removal) - Starting with Kubernetes v1.36, the gitRepo volume plugin is permanently disabled and cannot be turned back on. - Any workloads/POD specs that still use the gitRepo volume type will need to migrate (e.g., to initContainers or external git-sync style tooling), otherwise they will break. 2) Service.spec.externalIPs is deprecated (warn; removal planned later) - Kubernetes v1.36 marks Service.spec.externalIPs as deprecated. - Deprecation warnings will appear from v1.36 onward; Kubernetes states full removal is planned for v1.43. 3) Kubernetes v1.36 “Urgent Upgrade Notes” (actions required) - kube-controller-manager metric rename: volume_operation_total_errors was renamed to volume_operation_errors_total. - If you have custom monitoring/alerting dashboards based on the old metric name, you must update them. Where to read the official, complete list - Kubernetes v1.36 release announcement and links to the full release notes/changelog are published on the Kubernetes blog. - The authoritative per-feature deprecations/removals and upgrade notes are in the kubernetes/kubernetes CHANGELOG-1.36.md and are referenced by the v1.36.0 release tag. Practical upgrade checklist (based on the items above) - Search your manifests/Helm charts for “gitRepo” volumes and migrate them before upgrading to 1.36. - Search for “spec.externalIPs” usage and plan the migration away from it (removal targeted for 1.43). - Update monitoring/alerts for the kube-controller-manager metric rename (volume_operation_total_errors -> volume_operation_errors_total).
Citations:
- 1: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.36.md
- 2: https://github.com/kubernetes/kubernetes/releases/tag/v1.36.0
- 3: https://kubernetes.io/blog/2026/04/22/kubernetes-v1-36-release/
- 4: http://kubernetes.io/blog/2026/03/30/kubernetes-v1-36-sneak-peek/
- 5: https://kubernetes.io/blog/2026/03/30/kubernetes-v1-36-sneak-peek
🏁 Script executed:
#!/bin/bash
# Description: Search for Kubernetes API usage patterns that might be affected by version changes
# Search for deprecated API usage patterns or version-specific code
rg -n --type=go -C3 'k8s\.io/(api|apimachinery|client-go)' | head -100
# Check for any version-specific comments or TODO items related to Kubernetes
rg -n --type=go -i 'TODO.*k8s|FIXME.*kubernetes|k8s.*version'Repository: openshift/managed-cluster-validating-webhooks
Length of output: 7187
Review Kubernetes v1.36.0 breaking changes for compatibility.
Kubernetes v1.36.0 has been officially released and includes breaking changes that require validation:
- gitRepo volume driver is permanently disabled — Any Pod or Deployment specs using
gitRepovolumes will fail. Search manifests and validation rules for references to gitRepo volumes and ensure migration plans are in place. - Service.spec.externalIPs is deprecated — Deprecation warnings will appear; full removal is targeted for v1.43. Verify the codebase does not enforce or assume this field is available.
- kube-controller-manager metric rename —
volume_operation_total_errorsrenamed tovolume_operation_errors_total. Update monitoring/alerting if applicable.
Since this is a validation webhook repository, verify that webhook rules and validation logic do not assume these deprecated/removed features are available.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 19 - 22, The Kubernetes client bump to v0.36.0 may
introduce breaking changes; search and update webhook validation code (e.g., any
ValidateAdmissionReview/ValidatePodSpec/ValidateDeploymentSpec handlers and
related manifest validators) to (1) remove or explicitly reject gitRepo volume
references in Pod/Deployment specs and add migration guidance, (2) stop
enforcing or assuming Service.spec.externalIPs exists in validation logic and
handle its absence gracefully, and (3) update monitoring/alerting and any metric
names referenced in code/config from volume_operation_total_errors to
volume_operation_errors_total; also run tests against v1.36 API types to ensure
type/signature compatibility after the go.mod bump.
Bumps the kubernetes group with 2 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api) and [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver). Updates `k8s.io/api` from 0.35.4 to 0.36.0 - [Commits](kubernetes/api@v0.35.4...v0.36.0) Updates `k8s.io/apiextensions-apiserver` from 0.35.4 to 0.36.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.35.4...v0.36.0) Updates `k8s.io/apimachinery` from 0.35.4 to 0.36.0 - [Commits](kubernetes/apimachinery@v0.35.4...v0.36.0) Updates `k8s.io/client-go` from 0.35.4 to 0.36.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.35.4...v0.36.0) Updates `k8s.io/utils` from 0.0.0-20251002143259-bc988d571ff4 to 0.0.0-20260210185600-b8788abfbbc2 - [Commits](https://github.com/kubernetes/utils/commits) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apimachinery dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/client-go dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/utils dependency-version: 0.0.0-20260210185600-b8788abfbbc2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes ... Signed-off-by: dependabot[bot] <support@github.com>
c998624 to
c870654
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bumps the kubernetes group with 2 updates in the / directory: k8s.io/api and k8s.io/apiextensions-apiserver.
Updates
k8s.io/apifrom 0.35.4 to 0.36.0Commits
545bb97Update dependencies to v0.36.0 tag879d396Merge remote-tracking branch 'origin/master' into release-1.36030d81fUpdate github.com/moby/spdystream from v0.5.0 to v0.5.1aef6eb6Add granular authorization for DRA ResourceClaim status updates91061eaMerge pull request #136589 from tosi3k/preemption-modee6b81e2Add Workload-Aware Preemption fields to Workload and PodGroup APIsf8fce2eMerge pull request #136989 from nojnhuh/podgroup-resourceclaimb928f5eWorkload API: PodGroup ResourceClaims (KEP-5729)61bd78eMerge pull request #137190 from everpeace/KEP-5491-alpha6bf46ebMerge pull request #137028 from nmn3m/feature/dra-resource-pool-statusUpdates
k8s.io/apiextensions-apiserverfrom 0.35.4 to 0.36.0Commits
0ed55b7Update dependencies to v0.36.0 tag4cd8c3dMerge remote-tracking branch 'origin/master' into release-1.36c2fd557Merge pull request #138346 from dashpole/update_otel_prop1daa309Merge remote-tracking branch 'origin/master' into release-1.361551264Update github.com/moby/spdystream from v0.5.0 to v0.5.16c97d2bupdate go.opentelemetry.io/otel to v1.41.0862c52aupdate google.golang.org/grpc to v1.79.3abac065Merge pull request #137849 from bryantbiggs/deps/update-kube-openapi7acee75Merge pull request #137843 from pacoxu/cobra-v1.10.2612f1d8dependencies: bump kube-openapi to drop ginkgo/gomega indirect depsUpdates
k8s.io/apimachineryfrom 0.35.4 to 0.36.0Commits
debe1ebUpdate dependencies to v0.36.0 tagefb7f26Merge remote-tracking branch 'origin/master' into release-1.36d966e56Update github.com/moby/spdystream from v0.5.0 to v0.5.179b3632Merge pull request #137864 from yongruilin/dv-dra-mismatcha8822f7Add slice and map union member support with tests7dba2d0Use IsZero instead of IsNil for union ratcheting checkd95710fFix union validation ratcheting when oldObj is nil729062dMerge pull request #137849 from bryantbiggs/deps/update-kube-openapi13b12e6dependencies: bump kube-openapi to drop ginkgo/gomega indirect deps27f4670Merge pull request #136657 from Jefftree/sharding-testUpdates
k8s.io/client-gofrom 0.35.4 to 0.36.0Commits
1d95f02Update dependencies to v0.36.0 tagf22a53eMerge remote-tracking branch 'origin/master' into release-1.36a948641Update github.com/moby/spdystream from v0.5.0 to v0.5.17e44ffcAdd Workload-Aware Preemption fields to Workload and PodGroup APIsdf2d882Merge pull request #136989 from nojnhuh/podgroup-resourceclaim4eece52Workload API: PodGroup ResourceClaims (KEP-5729)3d35c51Merge pull request #137190 from everpeace/KEP-5491-alpha0434117Merge pull request #137028 from nmn3m/feature/dra-resource-pool-statusba785beDrop CSR analogy, mark ObjectMeta +required,reduce limits (maxItems=500, maxL...4a9c878Add ResourcePoolStatusRequest API types and generated codeUpdates
k8s.io/utilsfrom 0.0.0-20251002143259-bc988d571ff4 to 0.0.0-20260210185600-b8788abfbbc2Commits
Summary by CodeRabbit