fix make generate with tools
#263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to go install controller-gen and kube-openapi-gen The `go-get-tool` define from boilerplate was not useful. Signed-off-by: Swarup Ghosh <[email protected]>
* the kube-openapi-gen uses different flags from that of standard openapi-gen * controller-gen and openapi-gen binaries used were from path, using from ./bin/ instead Signed-off-by: Swarup Ghosh <[email protected]>
Signed-off-by: Swarup Ghosh <[email protected]>
Signed-off-by: Swarup Ghosh <[email protected]>
Member
Author
|
/cc @rausingh-rh |
openshift-ci
bot
requested review from
rausingh-rh,
shivprakashmuley and
vaidehi411
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@swghosh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe PR updates the project's tooling infrastructure by introducing a Makefile target to install controller-gen and openapi-gen binaries, reorganizes tool dependencies into a dedicated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
boilerplate/openshift/golang-osd-operator/standard.mk (1)
205-206: Tool paths are context-dependent and potentially fragile.The inconsistent path prefixes (
../bin/controller-genvs./bin/openapi-gen) reflect different execution contexts:CONTROLLER_GENis used aftercd ./api(line 213), whileOPENAPI_GENruns from the repository root. While functionally correct, this makes the build system fragile if invocation contexts change.Consider using absolute paths derived from
$(shell pwd)to make the build more robust:REPO_ROOT := $(shell pwd) CONTROLLER_GEN = $(REPO_ROOT)/bin/controller-gen OPENAPI_GEN = $(REPO_ROOT)/bin/openapi-gen
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (292)
go.sumis excluded by!**/*.sumvendor/github.com/fatih/color/LICENSE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/color.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/color_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/.gometalinter.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/SHOULDERS.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/acronyms.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/camelize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/capitalize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/custom_data.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/dasherize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/flect.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/humanize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/ident.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/lower_upper.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/ordinalize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/pascalize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/plural_rules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/pluralize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/rule.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/singular_rules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/singularize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/titleize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/underscore.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/gobuffalo/flect/version.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/compiler/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/compiler/extensions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/compiler/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/compiler/reader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/jsonschema/models.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/jsonschema/reader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/jsonschema/writer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/openapiv2/OpenAPIv2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/openapiv2/document.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/openapiv3/OpenAPIv3.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/gnostic-models/openapiv3/document.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/inconshreveable/mousetrap/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/inconshreveable/mousetrap/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/inconshreveable/mousetrap/trap_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/inconshreveable/mousetrap/trap_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_appengine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/go.test.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/noncolorable.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/go.test.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_plan9.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_tcgets.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/core_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/deprecated_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/formatter/formatter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/build/build_command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/command/abort.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/command/program.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/compile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/gocovmerge.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/watch_command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/ginkgo_t_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/failer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/interrupt_handler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/node.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_unix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/client_server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/server_handler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/report_entry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/suite.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/testingtproxy/testing_t_proxy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/internal/writer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/reporting_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/table_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/deprecated_types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/flags.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/label_filter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/report_entry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/ginkgo/v2/types/version.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/format/format.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/gcustom/make_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/gomega_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/assertion.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/async_assertion.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/duration_bundle.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/gomega.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/polling_signal_error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/vetoptdesc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/and.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/assignable_to_type_of_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_a_directory.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_a_regular_file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_an_existing_file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_closed_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_comparable_to_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_element_of_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_empty_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_equivalent_to_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_false_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_identical_to.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_key_of_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_nil_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_numerically_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_sent_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_temporally_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_true_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_zero_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/consist_of.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/contain_element_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/contain_elements_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/contain_substring_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/equal_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_cap_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_each_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_exact_elements.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_existing_field_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_http_body_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_http_header_with_value_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_http_status_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_key_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_len_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_occurred_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_prefix_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_suffix_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_value.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_error_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_json_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_regexp_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_xml_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/not.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/or.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/panic_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/receive_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/satisfy_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/semi_structured_data_support.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/succeed_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraph.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/support/goraph/node/node.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/type_support.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/with_transform.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/types/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/.mailmapis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/LICENSE.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/MAINTAINERSis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/active_help.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/args.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/bash_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/bash_completionsV2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/cobra.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/command_notwin.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/command_win.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/fish_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/flag_groups.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/powershell_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/shell_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/zsh_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/.golangci.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/flag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ip.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ipnet_slice.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/string_array.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/LICENSE.libyamlis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/NOTICEis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/apic.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/decode.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/emitterc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/encode.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/parserc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/readerc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/resolve.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/scannerc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/sorter.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/writerc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/yaml.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/yamlh.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v2/yamlprivateh.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/NOTICEis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/apic.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/decode.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/emitterc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/encode.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/parserc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/readerc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/resolve.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/scannerc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/sorter.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/writerc.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/yaml.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/yamlh.gois excluded by!vendor/**,!**/vendor/**vendor/go.yaml.in/yaml/v3/yamlprivateh.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/PATENTSis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/internal/lazyregexp/lazyre.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/module/module.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/module/pseudo.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/semver/semver.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/context/context.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_darwin.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.sis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsyscall_darwin_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsyscall_darwin_arm64.sis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/types_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/term/terminal.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/enclosing.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/imports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/rewrite.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/inspector.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/iter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/typeof.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/walk.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/gcexportdata/gcexportdata.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/gcexportdata/importer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/external.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/golist.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/golist_overlay.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/loadmode_string.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/packages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/visit.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/callee.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/imports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/map.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/methodsetcache.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/ui.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/imports/forward.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/aliases/aliases.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/aliases/aliases_go122.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/edge/edge.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/core/event.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/core/export.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/core/fast.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/event.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/keys/keys.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/keys/standard.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/keys/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/bimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/exportdata.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/gcimporter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iimport_go122.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (8)
.gitignore(1 hunks)Makefile(1 hunks)api/v1alpha1/zz_generated.openapi.go(1 hunks)boilerplate/openshift/golang-osd-operator/standard.mk(2 hunks)deploy/crds/managed.openshift.io_mustgathers.yaml(1 hunks)go.mod(7 hunks)tools.go(0 hunks)tools/tools.go(1 hunks)
💤 Files with no reviewable changes (1)
- tools.go
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
api/v1alpha1/zz_generated.openapi.goboilerplate/openshift/golang-osd-operator/standard.mktools/tools.godeploy/crds/managed.openshift.io_mustgathers.yamlMakefilego.mod
🪛 checkmake (0.2.2)
Makefile
[warning] 23-23: Missing required phony target "all"
(minphony)
[warning] 23-23: Missing required phony target "clean"
(minphony)
[warning] 23-23: Missing required phony target "test"
(minphony)
🔇 Additional comments (8)
.gitignore (1)
90-91: LGTM!The addition of
bin/to ignore binaries produced by the newinstall-toolstarget is appropriate and necessary.deploy/crds/managed.openshift.io_mustgathers.yaml (1)
6-6: LGTM!The controller-gen version annotation update to v0.18.0 aligns with the tooling changes in the PR and matches the version in go.mod.
tools/tools.go (1)
1-10: LGTM!This follows the standard Go pattern for declaring tool dependencies as side-effect imports, ensuring
go moddownloads and manages these tools correctly.Makefile (1)
23-26: LGTM!The
install-toolstarget correctly uses the macro to install both controller-gen and openapi-gen into the bin/ directory.boilerplate/openshift/golang-osd-operator/standard.mk (1)
217-226: LGTM!The
openapi-generatetarget correctly invokes the new tool with appropriate flags for output directory, package, and file generation.go.mod (2)
8-9: LGTM!The dependency updates for testing frameworks (ginkgo/gomega), kube-openapi, and controller-tools align with the tooling infrastructure changes and support the new
install-toolsworkflow.Also applies to: 19-19, 21-21
36-115: Dependency updates look consistent.The indirect dependency updates across the Go ecosystem (stdlib extensions, Kubernetes tooling, formatting libraries) are routine version bumps that support the tooling changes.
api/v1alpha1/zz_generated.openapi.go (1)
12-14: Clarify whether the empty OpenAPI definitions are intentional or a side effect of code generation.The file is auto-generated by openapi-gen, but a discrepancy exists: the
// +k8s:openapi-gen=truemarker remains on line 64 ofmustgather_types.go, yet the generatedzz_generated.openapi.goreturns an empty map despite struct types (MustGatherSpec,ProxySpec,MustGather, etc.) being defined.Either:
- Remove the
// +k8s:openapi-gen=truemarker if OpenAPI schemas are no longer needed for this API version, or- Investigate why the marker is present but no schemas are generated.
This inconsistency should be clarified to avoid confusion during future maintenance.
Comment on lines
+12
to
+21
| # go-install-tool will 'go install' any package $2 and install it to $1. | ||
| define go-install-tool | ||
| @{ \ | ||
| set -e ;\ | ||
| echo "Downloading $(2)" ;\ | ||
| GOBIN=$(shell dirname $(1)) go install $(2) ;\ | ||
| echo "Installed in $(1)" ;\ | ||
| rm -rf $$TMP_DIR ;\ | ||
| } | ||
| endef |
There was a problem hiding this comment.
Remove unused TMP_DIR cleanup.
The macro references $$TMP_DIR on line 19 but never creates it. This appears to be residual code from a copy-paste of the go-get-tool macro in standard.mk (which does create and use TMP_DIR).
Apply this diff to remove the unused cleanup:
define go-install-tool
@{ \
set -e ;\
echo "Downloading $(2)" ;\
GOBIN=$(shell dirname $(1)) go install $(2) ;\
echo "Installed in $(1)" ;\
-rm -rf $$TMP_DIR ;\
}
endef🤖 Prompt for AI Agents
In Makefile around lines 12 to 21, the go-install-tool macro calls rm -rf
$$TMP_DIR even though TMP_DIR is never created or used; remove the unused
cleanup line (rm -rf $$TMP_DIR) from the macro so it no longer references a
non-existent TMP_DIR and leave the rest of the macro intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*-gentools