Skip to content

Conversation

@LiZhang19817
Copy link
Contributor

Summary

  • Add new periodic CI job for Quay 3.16 API testing with new UI
  • Update test script to conditionally use new UI Cypress spec for version 3.16
  • Update default Quay version from 3.15 to 3.16

Changes

New Periodic Job

  • Added quay-e2e-tests-quay316-api-testing periodic job in ci-operator/config/quay/quay-tests/quay-quay-tests-master__quay-api.yaml:95-107
  • Runs monthly on the 6th day at midnight (cron: 0 0 6 * *)
  • Configuration:
    • Quay version: 3.16
    • Operator channel: stable-3.16
    • Index image: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-16-v4-20@sha256:cd002d9f0913444e26f901c7dccdfc7428c3ceec691cf5404ec08afeb2ce65ff
    • Cluster profile: aws-quay-qe
    • Compute node type: m5.2xlarge

Test Script Enhancement

  • Modified ci-operator/step-registry/quay-tests/test/quay-api/quay-tests-test-quay-api-commands.sh:19-27
  • Conditionally selects Cypress spec based on QUAY_VERSION environment variable:
    • Version 3.16: uses cypress/e2e/quay_api_testing_all_new_ui.cy.js (new UI)
    • Other versions: uses cypress/e2e/quay_api_testing_all.cy.js (standard)
  • This allows backward compatibility while supporting new UI testing for 3.16

Configuration Updates

  • Updated default QUAY_VERSION from "3.15" to "3.16" in ci-operator/step-registry/quay-tests/test/quay-api/quay-tests-test-quay-api-ref.yaml:24
  • Regenerated Prow job configurations via make update

Files Changed

  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__quay-api.yaml (+15 lines)
  • ci-operator/jobs/quay/quay-tests/quay-quay-tests-master-periodics.yaml (+82 lines, auto-generated)
  • ci-operator/step-registry/quay-tests/test/quay-api/quay-tests-test-quay-api-commands.sh (+13, -1)
  • ci-operator/step-registry/quay-tests/test/quay-api/quay-tests-test-quay-api-ref.yaml (+1, -1)

Test Plan

  • New periodic job will execute monthly to validate Quay 3.16 API functionality with new UI
  • Existing API testing jobs for other Quay versions remain unchanged and unaffected
  • The conditional spec selection ensures proper test execution based on version

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@LiZhang19817
Copy link
Contributor Author

/pj-rehearse periodic-ci-quay-quay-tests-master-quay-api-quay-e2e-tests-quay316-api-testing

@openshift-ci-robot
Copy link
Contributor

@LiZhang19817: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@LiZhang19817
Copy link
Contributor Author

/pj-rehearse periodic-ci-quay-quay-tests-master-quay-api-quay-e2e-tests-quay316-api-testing

@openshift-ci-robot
Copy link
Contributor

@LiZhang19817: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@LiZhang19817
Copy link
Contributor Author

/pj-rehearse periodic-ci-quay-quay-tests-master-quay-api-quay-e2e-tests-quay316-api-testing

@openshift-ci-robot
Copy link
Contributor

@LiZhang19817: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@LiZhang19817
Copy link
Contributor Author

/pj-rehearse periodic-ci-quay-quay-tests-master-quay-api-quay-e2e-tests-quay316-api-testing

@openshift-ci-robot
Copy link
Contributor

@LiZhang19817: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@LiZhang19817
Copy link
Contributor Author

/pj-rehearse periodic-ci-quay-quay-tests-master-quay-api-quay-e2e-tests-quay316-api-testing

@openshift-ci-robot
Copy link
Contributor

@LiZhang19817: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

LiZhang19817 and others added 5 commits November 10, 2025 16:00
Add missing line continuation backslash for multi-line command with output redirection. Resolves shellcheck errors SC1073 and SC1072.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Fix "QuayRegistry CRD not found" error by adding the missing
QUAY_OPERATOR_SOURCE environment variable to the quay-e2e-tests-quay316-api-testing
job configuration. Without this variable, the CatalogSource creation fails,
preventing the Quay Operator from installing and registering the QuayRegistry CRD.

Setting QUAY_OPERATOR_SOURCE to fbc-operator-catalog to match other Quay 3.16 jobs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Fix Cypress test failures caused by Node.js v22 compatibility issues.
The latest LTS Node.js (v22.x) is incompatible with Cypress 12.6.0,
causing "ERR_FAILED (-2) loading 'about:blank#blocked'" errors.

Pinning to Node.js 20.x resolves the issue while maintaining LTS support.

Error details:
- The new-window event is deprecated in Electron 106 (bundled with Cypress 12.6.0)
- Node.js v22 has stricter security policies that block Electron initialization
- This affects all tests using the quay-test-console image including
  the quay-e2e-tests-quay316-api-testing job

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@LiZhang19817 LiZhang19817 force-pushed the add-quay316-api-testing-job-new-ui branch from 433b81d to 80293d1 Compare November 10, 2025 08:02
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@LiZhang19817: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-quay-quay-tests-master-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-omr-ocp416-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-quay-dast-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-quay-newui-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-quay-newui-stress-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-quay-upgrade-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-quay-upgrade-ocp417-images quay/quay-tests presubmit Ci-operator config changed
pull-ci-quay-quay-tests-master-stage-quay-io-images quay/quay-tests presubmit Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-ocp418-gcp N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-quay-rosa-ocp-quay-e2e-tests-quay313-rosa-ocp419 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-omr-ocp416-unreleased-quay-omr-tests-omr-ocp416-disconnected-unreleased N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-ocp418-fips N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-ocp418-lp-interop-fips N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-aws-s3-rds-postgresql14-ocp418 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-quay-api-quay-e2e-tests-quay314-api-testing N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-omr-ocp412-unreleased-quay-omr-tests-omr-ocp412-disconnected-unreleased N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-omr-ocp414-quay-omr-tests-omr-ocp414-disconnected N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-420-quay-quay-e2e-tests-quay314-ocp420-lp-interop N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay314-aro-ocp419 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay314-ocp418-aws-sts N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay312-aro-ocp419 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-quay-sdl-quay-sdl-check-images-vulnerabilities-quay39 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-419-quay-quay-e2e-tests-quay315-ocp419 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-418-quay-quay-e2e-tests-quay313-aws-s3-rds-postgresql13-ocp418 N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-quay-upgrade-ocp417-quay315-ocp417-upgrade N/A periodic Ci-operator config changed

A total of 115 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@LiZhang19817
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@LiZhang19817: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 10, 2025
@LiZhang19817
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 10, 2025
@dongboyan77
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongboyan77, LiZhang19817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d85efe3 into openshift:master Nov 10, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants