Skip to content

Conversation

@slawqo
Copy link
Contributor

@slawqo slawqo commented Nov 7, 2025

With [1] PVCs which are created for the OVN databases aren't cleaned automatically thus we should have more than 12 PVs created in the kuttl job so that each test will use different PVs and there will be no old data on the used PV.

[1] openstack-k8s-operators/ovn-operator#511

Related: #OSPRH-19930

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

@slawqo, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error converting YAML to JSON: yaml: line 90: could not find expected ':')
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

slawqo added a commit to slawqo/ovn-operator that referenced this pull request Nov 7, 2025
Synchronization of the OVN dbs with Neutron is pretty heavy and manual
operation it is benefical to not delete those OVN databases when
OVNDBCluster's PODs are deleted.
To achieve that this patch removes `OwnerReference` attribute from the
PVCs created for the OVNDBClusters so that they are not cleaned by the
OpenShift's garbage collector and it also changes
PersistentVolumeClaimRetentionPolicy when deleted and when scaled to the
same `Retain` policy.

Depends-On: openshift/release#71153

Closes: #OSPRH-19930

Signed-off-by: Slawek Kaplonski <[email protected]>
With [1] PVCs which are created for the OVN databases aren't cleaned
automatically thus we should have more than 12 PVs created in the kuttl
job so that each test will use different PVs and there will be no old
data on the used PV.

[1] openstack-k8s-operators/ovn-operator#511

Related: #OSPRH-19930

Signed-off-by: Slawek Kaplonski <[email protected]>
@slawqo slawqo force-pushed the issue/OSPRH-19930 branch from 6ca6704 to 60293ef Compare November 7, 2025 13:27
@slawqo
Copy link
Contributor Author

slawqo commented Nov 7, 2025

/pj-rehearse ovn-operator-build-deploy-kuttl

@openshift-ci-robot
Copy link
Contributor

@slawqo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@averdagu
Copy link

averdagu commented Nov 7, 2025

Change looks good to me, waiting for jobs to finish to give approve

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@slawqo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-ovn-operator-main-ovn-operator-build-deploy-kuttl openstack-k8s-operators/ovn-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@slawqo: job(s): ovn-operator-build-deploy-kuttl either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

@slawqo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config 60293ef link true /test ci-operator-config
ci/prow/ci-operator-config-metadata 60293ef link true /test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants