ACM-26177: Update branch protections for console repository. #71169
Conversation
Signed-off-by: Randy Bruno Piverger <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@Randy424: This pull request references ACM-26177 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.21." or "openshift-4.21.", but it targets "ACM 2.16.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Randy424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I've included the entire set of PR checks going back to release 2.9 (as opposed to just the Konflux checks...). Please let me know if we would prefer to have only the later. 
|
openshift-ci-robot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] |
| protect: true | ||
| required_pull_request_reviews: | ||
| dismiss_stale_reviews: true | ||
| required_approving_review_count: 2 |
There was a problem hiding this comment.
required_approving_review_count remains at 2.
There was a problem hiding this comment.
I would change this to 1 since it says 2 on the PR but isn't enforced... and it always trips people up.
There was a problem hiding this comment.
I've had an issue open upstream on this, but no resolution in sight for it:
|
@Randy424: This pull request references ACM-26177 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.21." or "openshift-4.21.", but it targets "ACM 2.16.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dhaiducek
left a comment
dhaiducek
left a comment
There was a problem hiding this comment.
LGTM! I've left a couple comments to consider.
| dismiss_stale_reviews: true | ||
| required_approving_review_count: 2 | ||
| branches: | ||
| release-2.9: |
There was a problem hiding this comment.
This can be removed if you want to simplify your configuration--release-2.9 and release-2.10 are no longer supported.
| - ci/prow/check | ||
| - ci/prow/images | ||
| - ci/prow/pr-image-mirror | ||
| - ci/prow/pr-image-mirror-mce | ||
| - dco | ||
| - tide |
There was a problem hiding this comment.
It's fine to leave these here, but Prow will also detect its own jobs and mark them required if you want to leave them off.
There was a problem hiding this comment.
Yeah, let's keep it simple and only list Konflux jobs.
There was a problem hiding this comment.
@Randy424 We need to include the backplane-* branches as well, and list that they require Konflux checks. This is part of the magic - since we never configure our backplane branch to run PR checks, this will prevent people from checking in directly to a backplane branch instead of the corresponding release branch.
4 participants
Regarding: https://issues.redhat.com/browse/ACM-26177
Update branch protections to require the correct Konflux jobs to run.