Skip to content

[wip] reserve cluster - #85487

Open
wainersm wants to merge 1 commit into
openshift:mainfrom
wainersm:dev_azure-ipi-peerpods
Open

wainersm wants to merge 1 commit into
openshift:mainfrom
wainersm:dev_azure-ipi-peerpods

Conversation

@wainersm

@wainersm wainersm commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

The openshift/sandboxed-containers-operator downstream candidate configuration updates the azure-ipi-peerpods periodic job to:

  • Restrict network access.
  • Keep the job active for 8 hours instead of exiting immediately.

This supports reserving the Azure cluster for the job duration.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2026
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 54e5f72c-05f9-45ec-a486-d0e8ab8c0953

📥 Commits

Reviewing files that changed from the base of the PR and between 2a54bd7 and d1d4b46.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/sandboxed-containers-operator/openshift-sandboxed-containers-operator-devel__downstream-candidate422.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The downstream-candidate422 Azure IPI PeerPods periodic job now restricts network access and sleeps for eight hours.

Changes

Azure PeerPods CI

Layer / File(s) Summary
Azure IPI PeerPods job settings
ci-operator/config/openshift/sandboxed-containers-operator/openshift-sandboxed-containers-operator-devel__downstream-candidate422.yaml
The job sets restrict_network_access to true and SLEEP_DURATION to 8h.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: tbuskey

Merge Risk: ⚪ Minimal · up to d1d4b

No review-blocking behavior is identified in this configuration-only change.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title, "[wip] reserve cluster," describes the configuration change that keeps the Azure IPI PeerPods cluster reserved for 8 hours. It is concise and related to the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only one YAML CI configuration. The exact diff changes restrict_network_access from false to true and SLEEP_DURATION from 0h to 8h. It does not change any Ginkgo t…
Test Structure And Quality ✅ Passed PASS: The pull request changes only one YAML CI configuration file. The patch changes restrict_network_access and SLEEP_DURATION for the azure-ipi-peerpods job. It does not add or modify Ginkgo …
Microshift Test Compatibility ✅ Passed The pull request changes only one CI YAML file. The authoritative diff modifies restrict_network_access and SLEEP_DURATION for the existing azure-ipi-peerpods job. It adds no Ginkgo tests, test …
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes one CI YAML file only. The patch changes restrict_network_access from false to true and SLEEP_DURATION from 0h to 8h for azure-ipi-peerpods. It adds no Ginkgo tests or tes…
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only one CI job configuration file. It changes restrict_network_access from false to true and SLEEP_DURATION from 0h to 8h for azure-ipi-peerpods. The changed fi…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only one YAML CI configuration file. The diff changes restrict_network_access and SLEEP_DURATION for the azure-ipi-peerpods job. It does not change OTE binaries, G…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only one CI YAML file. Its diff updates azure-ipi-peerpods configuration (restrict_network_access: false to true and SLEEP_DURATION: 0h to 8h). It adds no Ginkgo tes…
No-Weak-Crypto ✅ Passed PASS. The authoritative pull-request diff contains one YAML file and changes only restrict_network_access from false to true and SLEEP_DURATION from 0h to 8h for azure-ipi-peerpods. The …
Container-Privileges ✅ Passed PASS. The pull request changes only restrict_network_access: false to true and SLEEP_DURATION: 0h to 8h in one CI job. The changed file contains no privileged, host namespace, SYS_ADMIN, `…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes only restrict_network_access from false to true and SLEEP_DURATION from 0h to 8h for the azure-ipi-peerpods job. These settings restrict network access and…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from gkurz and ldoktor September 18, 2026 14:19
@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wainersm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2026
@wainersm

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-sandboxed-containers-operator-devel-downstream-candidate422-azure-ipi-peerpods

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@wainersm: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@wainersm: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant