Skip to content

fix: claim abandoned quay-tests secrets - #85497

Open
cubismod wants to merge 1 commit into
openshift:mainfrom
cubismod:claim-quay-tests-quay-devel
Open

cubismod wants to merge 1 commit into
openshift:mainfrom
cubismod:claim-quay-tests-quay-devel

Conversation

@cubismod

@cubismod cubismod commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

#84747 moved quay-tests secret group to be unclaimed as there was no rover group associated with this.

This PR stakes an ownership claim for quay-devel the Quay.io upstream & downstream teams.

https://redhat.atlassian.net/browse/QUAYIO-2267

This is necessary for updating our orion credentials which have been rotated due to a leak.

Summary by CodeRabbit

  • Assigns the quay-tests secret collection to the quay-devel Rover group.
  • Transfers ownership from the unclaimed secrets group so Quay teams can manage rotated Orion credentials.

@openshift-ci
openshift-ci Bot requested review from Prucek and deepsm007 September 18, 2026 17:12
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: fa25ddb5-3091-42f9-8eae-b0d17e10a0ab

📥 Commits

Reviewing files that changed from the base of the PR and between eeb1bfd and 935beaf.

📒 Files selected for processing (1)
  • core-services/sync-rover-groups/_config.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The configuration moves the quay-tests secret collection from test-platform-gsm-unclaimed-secrets to quay-devel. The quay-devel group retains its app.ci cluster reference.

Changes

Secret collection ownership

Layer / File(s) Summary
Reassign quay-tests collection
core-services/sync-rover-groups/_config.yaml
quay-devel now lists quay-tests under secret_collections. The entry is removed from test-platform-gsm-unclaimed-secrets, which remains marked unclaimed: true.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to 935be

The ownership transfer is complete and leaves the secret collection operationally defined, so the change is ready to merge.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: claiming ownership of the previously unclaimed quay-tests secrets for the quay-devel Rover group.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The check is not applicable to this pull request. The reviewed range changes only core-services/sync-rover-groups/_config.yaml, moving quay-tests from the unclaimed collection to quay-devel. The…
Test Structure And Quality ✅ Passed PASS: The pull request changes only core-services/sync-rover-groups/_config.yaml. The diff moves quay-tests from test-platform-gsm-unclaimed-secrets to quay-devel and adds no Ginkgo tests, `It…
Microshift Test Compatibility ✅ Passed The check is not applicable. The pull request changes only core-services/sync-rover-groups/_config.yaml, moving the quay-tests secret collection to quay-devel. It adds no Ginkgo tests, test decl…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves quay-tests ownership from test-platform-gsm-unclaimed-secrets to quay-devel. It adds no Ginkgo tests …
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves quay-tests from the unclaimed secret collection list to the quay-devel Rover group. It adds no deployme…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves quay-tests from the unclaimed group to quay-devel. The diff introduces no OTE binary code, suite setup,…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves the quay-tests secret collection to the quay-devel group. It adds no Ginkgo tests, network code, IP handling,…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves the quay-tests collection from test-platform-gsm-unclaimed-secrets to quay-devel. The diff adds two Y…
Container-Privileges ✅ Passed PASS: The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves quay-tests from the unclaimed secret collection to quay-devel. The changed lines do not introduce a Kub…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. It moves the quay-tests collection reference from the unclaimed group to quay-devel. The diff adds no logging co…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cubismod
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@cubismod: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 18, 2026
@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@cubismod: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jbpratt

jbpratt commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubismod can you please update it to claim the other quay secrets as well?

@jbpratt

jbpratt commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants