coreos/coreos-assembler: specify pull credentials namespace

[Rolv-Apneseth]

Use the test-credentials namespace for the RHCOS build test, since without it the test is failing and blocking CI.

Companion to #85279, but for coreos-assembler to fix CI there (e.g. see coreos/coreos-assembler#4616 (comment)).

Summary by CodeRabbit

The coreos/coreos-assembler RHCOS build test now sources ci-pull-credentials from the test-credentials namespace. This provides the Docker credentials required by the RHCOS build command and supports CI reliability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: e1880419-944b-46a1-9486-b65b56dcf924

📥 Commits

Reviewing files that changed from the base of the PR and between 2fc82f9 and 8ccd9ef.

📒 Files selected for processing (1)

• ci-operator/config/coreos/coreos-assembler/coreos-coreos-assembler-main.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

Changes

RHCOS secret configuration

Layer / File(s)	Summary
Pin credential secret namespace ci-operator/config/coreos/coreos-assembler/coreos-coreos-assembler-main.yaml	The rhcos test now sources the ci-pull-credentials secret bundle from the test-credentials namespace.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to 8ccd9

This configuration change addresses the intended CI credential lookup without introducing an identified merge risk.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: specifying the namespace for pull credentials in coreos/coreos-assembler.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes one YAML field: secret.namespace: test-credentials. The authoritative diff contains no Ginkgo declarations or test-title construction. The existing test name rhcos i…
Test Structure And Quality	✅ Passed	PASS. The pull request changes one YAML configuration file and adds only namespace: test-credentials to the ci-pull-credentials secret declaration. It does not change Ginkgo tests, setup or cleanu…
Microshift Test Compatibility	✅ Passed	The pull request changes only ci-operator/config/coreos/coreos-assembler/coreos-coreos-assembler-main.yaml. It adds namespace: test-credentials to the ci-pull-credentials secret configuration. I…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only the CI YAML for the existing rhcos test. It adds namespace: test-credentials to the ci-pull-credentials secret bundle. It does not add or modify Ginkgo e2e tests, n…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only the CI test secret configuration. It adds namespace: test-credentials under the ci-pull-credentials secret bundle. It does not add or modify a deployment, opera…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes one YAML field only: secret.namespace: test-credentials in the rhcos test. The added line does not contain process-level code or any stdout write. The unchanged comm…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes one YAML field: it adds namespace: test-credentials to the existing rhcos secret declaration. It does not add or modify Ginkgo e2e test code, IPv4 addresses, network parsi…
No-Weak-Crypto	✅ Passed	PASS. The pull request adds only namespace: test-credentials to the existing ci-pull-credentials secret declaration. The changed file contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom c…
Container-Privileges	✅ Passed	The pull request changes only the secret namespace to test-credentials. The added line is not a privilege setting, and the changed manifest contains no privileged: true, host namespace settings, `…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only the secret bundle namespace to test-credentials. The diff adds no logging, output, credentials, tokens, hostnames, or customer data. The existing command still pa…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Rolv-Apneseth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-coreos-coreos-assembler-main-rhcos	coreos/coreos-assembler	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Rolv-Apneseth]

/pj-rehearse pull-ci-coreos-coreos-assembler-main-rhcos

[openshift-merge-bot]

@Rolv-Apneseth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[marmijo]

/lgtm

[dustymabe]

LGTM

[dustymabe]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, marmijo, Rolv-Apneseth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/coreos/coreos-assembler/OWNERS [Rolv-Apneseth,dustymabe,marmijo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dustymabe]

/pj-rehearse auto-ack

[openshift-merge-bot]

@dustymabe: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@Rolv-Apneseth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.