OCPBUGS-49908: dynamicallyReplaceEndpoints: Check for idled svc

[Miciah]

When dynamically replacing a route's endpoints, force a reload if the new endpoints include an endpoint for an idled service.

Before this change, the Dynamic Configuration Manager could replace an active endpoint that had the health check enabled with the endpoint for an idled service, leaving the health check enabled for the idled service. The health check could then cause the idled service to be unidled. This commit inhibits dynamic updates for a route that has an idled endpoint; this means that the router follows the conventional update logic, which does not enable health checks for idled services.

---

Once this PR merges, we need to post a revert of openshift/api#2552 to move DCM back to TPNU.

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-49908, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "4.21.0" version, but no target version was set
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Won't Do) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When dynamically replacing a route's endpoints, force a reload if the new endpoints include an endpoint for an idled service.

Before this change, the Dynamic Configuration Manager could replace an active endpoint that had the health check enabled with the endpoint for an idled service, leaving the health check enabled for the idled service. The health check could then cause the idled service to be unidled. This commit inhibits dynamic updates for a route that has an idled endpoint; this means that the router follows the conventional update logic, which does not enable health checks for idled services.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Miciah]

/jira refresh

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-49908, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[candita]

/assign @rikatz @grzpiotrowski

[rikatz]

looks good to me, thanks for the detailed explanation.

Will leave the lgtm for @grzpiotrowski

[rikatz]

/cc @lihongan @ShudiLi @rhamini3

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grzpiotrowski]

/lgtm

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-49908, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

When dynamically replacing a route's endpoints, force a reload if the new endpoints include an endpoint for an idled service.

Before this change, the Dynamic Configuration Manager could replace an active endpoint that had the health check enabled with the endpoint for an idled service, leaving the health check enabled for the idled service. The health check could then cause the idled service to be unidled. This commit inhibits dynamic updates for a route that has an idled endpoint; this means that the router follows the conventional update logic, which does not enable health checks for idled services.

--

Once this PR merges, we need to post a revert of openshift/api#2552 to move DCM back to TPNU.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamini3]

marking bug as verified tested on 4.21.0-0-2025-12-01-155130-test-ci-ln-sxt0lpb-latest

ran Idling with a single service and ReplicationController should idle the service and ReplicationController properly test 3 times with successful runs each time

Router Deployment has DCM enabled

          - name: ROUTER_HAPROXY_CONFIG_MANAGER
            value: "true"

  Ran 1 of 1 Specs in 24.378 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "[sig-network-edge][Feature:Idling] Idling with a single service and ReplicationController should idle the service and ReplicationController properly [Suite:openshift/conformance/parallel]",
    "lifecycle": "blocking",
    "duration": 24378,
    "startTime": "2025-12-01 18:21:03.102579 UTC",
    "endTime": "2025-12-01 18:21:27.481234 UTC",
    "result": "passed",

/verified by @rhamini3

[openshift-ci-robot]

@rhamini3: This PR has been marked as verified by @rhamini3.

In response to this:

marking bug as verified tested on 4.21.0-0-2025-12-01-155130-test-ci-ln-sxt0lpb-latest

ran Idling with a single service and ReplicationController should idle the service and ReplicationController properly test 3 times with successful runs each time

/verified by @rhamini3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0e388de and 2 for PR HEAD bee7676 in total

[openshift-ci]

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@Miciah: Jira Issue Verification Checks: Jira Issue OCPBUGS-49908
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-49908 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

When dynamically replacing a route's endpoints, force a reload if the new endpoints include an endpoint for an idled service.

Before this change, the Dynamic Configuration Manager could replace an active endpoint that had the health check enabled with the endpoint for an idled service, leaving the health check enabled for the idled service. The health check could then cause the idled service to be unidled. This commit inhibits dynamic updates for a route that has an idled endpoint; this means that the router follows the conventional update logic, which does not enable health checks for idled services.

---

Once this PR merges, we need to post a revert of openshift/api#2552 to move DCM back to TPNU.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.