CORE-1094: Rex: Highlight box remains at the top of the page when scroll-highlighting text #2639
Conversation
rather than adding to global.d.ts
RoyEJohnson
left a comment
RoyEJohnson
left a comment
There was a problem hiding this comment.
I have rebased and added a couple of small commits (explained in my comments).
I'm finding that when I extend my selection forward, the instruction box moves down, but when I extend upward (by shift-clicking before the start of the selection), it does not move.
If I select by dragging so that the page auto-scrolls while dragging, the box winds up a little below the frame (since the selected text goes right to the bottom of the viewport).
Do you think you can force the box into the viewport when the selection changes?
| selection.focusNode | ||
| ); | ||
|
|
||
| // tslint:disable-next-line:no-bitwise |
There was a problem hiding this comment.
While you were working on this, tslint got removed from the stack. Eslint is the only linter. I added a commit to add the no-bitwise rule and changed the comment accordingly.
src/typings/global.d.ts
Outdated
|
|
||
| declare global { | ||
|
|
||
| type DomSelection = Selection; |
There was a problem hiding this comment.
Rather than adding types here, I've imported the types where they are used in another commit.
CORE-1094