feat(sdk): add ForAction helper to authorization/v2

[marythought]

Problem

The authorization/v2 package provides ergonomic constructor helpers — ForToken(), ForEmail(), ForAttributeValues(), etc. — so consumers can build a GetDecisionRequest without importing internal proto packages. There is no equivalent helper for the request's Action field, so callers must import the policy package directly and hand-build the value:

import (
    authorizationv2 "github.com/opentdf/platform/protocol/go/authorization/v2"
    "github.com/opentdf/platform/protocol/go/policy"
)

req := &authorizationv2.GetDecisionRequest{
    EntityIdentifier: authorizationv2.ForToken(jwt),
    Action:           &policy.Action{Name: "decrypt"},
    Resource:         authorizationv2.ForAttributeValues("https://example.com/attr/classification/value/confidential"),
}

This forces an extra import and leaks the policy package into consumer code.

Change

Add ForAction(name string) *policy.Action, authored in protocol/go/internal/authorization/v2/action.go and copied into the public package via protocol/codegen (action.gen.go), following the same pattern as entity_identifier and resource.

req := &authorizationv2.GetDecisionRequest{
    EntityIdentifier: authorizationv2.ForToken(jwt),
    Action:           authorizationv2.ForAction("decrypt"),
    Resource:         authorizationv2.ForAttributeValues("https://example.com/attr/classification/value/confidential"),
}

Because ForAction returns a *policy.Action (a different proto package), the codegen preserves the policy import and qualifier in the generated file — only the self-referencing authorizationv2 alias is stripped.

Testing

• make proto-helper-generate regenerates action.gen.go
• go test ./protocol/go/internal/authorization/v2/... — pass (new action_test.go)
• go build / go vet / golangci-lint run on protocol/go authz v2 packages — clean

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added a convenient helper for creating authorization actions from a name.
  • Supports both named and empty action values.

• Tests

  • Added coverage verifying that action names are preserved correctly.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5dc3c33d-81d7-4d8c-8b96-bfeaaa4768bf

📥 Commits

Reviewing files that changed from the base of the PR and between 88e21dc and 35e8a36.

📒 Files selected for processing (3)

• protocol/go/authorization/v2/action.gen.go
• protocol/go/internal/authorization/v2/action.go
• protocol/go/internal/authorization/v2/action_test.go

---

📝 Walkthrough

Walkthrough

Adds ForAction helpers to generated and internal authorization packages, returning policy actions populated with supplied names, plus tests for non-empty and empty names.

Changes

Authorization action helper

Layer / File(s)	Summary
Action helper implementation and validation protocol/go/authorization/v2/action.gen.go, protocol/go/internal/authorization/v2/action.go, protocol/go/internal/authorization/v2/action_test.go	The generated and internal packages add ForAction helpers that create *policy.Action values, with tests covering non-empty and empty names.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

I’m a rabbit with an action to name,
ForAction makes the policy game.
Empty or bright, the names pass through,
Tests hop along to check them too.
Wiggle ears—helper work is done!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding a ForAction helper to authorization/v2.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dspx-3378-foraction-helper

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	188.26299ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	105.790007ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	438.454926ms
Throughput	228.07 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	49.612158867s
Average Latency	493.821349ms
Throughput	100.78 requests/second

[github-actions]

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

• examples
• otdfctl
• sdk
• service
• lib/fixtures
• tests-bdd

See the workflow run for details.

[github-actions]

X-Test Results

✅ go@main-pull-3783
✅ go@main-main
✅ go@main-v0.9.0
✅ go@pull-3783-v0.9.0
✅ go@pull-3783-pull-3783
✅ go@pull-3783-main
✅ java@main-main
✅ java@main-pull-3783
✅ js@main-pull-3783
✅ java@main-v0.9.0
✅ js@main-main
✅ js@main-v0.9.0
cukes-report
opentdfplatformBA3TMU.dockerbuild
govulncheck-failure-3
govulncheck-failure-0
govulncheck-failure-8
govulncheck-failure-5
govulncheck-failure-2
govulncheck-failure-1

[marythought]

Codex review:

LGTM ✅
Nice addition — ForAction(...) rounds out the v2 helper set and keeps call sites cleaner by avoiding direct policy imports for common decision requests.
What I checked:
Helper implementation in generated and internal packages matches existing helper patterns.
Unit tests cover both normal and empty-string inputs.
Focused package tests pass:go test ./protocol/go/internal/authorization/v2
go test ./protocol/go/authorization/v2

No blocking issues from my review.