Skip to content

fix(xtest): Adds back java-sdk mlkem feature#550

Open
dmihalcik-virtru wants to merge 1 commit into
mainfrom
revert-540-disable-pure-mlkem-java-sdk
Open

fix(xtest): Adds back java-sdk mlkem feature#550
dmihalcik-virtru wants to merge 1 commit into
mainfrom
revert-540-disable-pure-mlkem-java-sdk

Conversation

@dmihalcik-virtru

@dmihalcik-virtru dmihalcik-virtru commented Jul 7, 2026

Copy link
Copy Markdown
Member

Reverts #540

Summary by CodeRabbit

  • Bug Fixes
    • Updated feature detection to recognize support for a new ML-KEM encryption mechanism.
    • Improved the support check to validate encryption help output more reliably and report support status through the command’s exit code.

@dmihalcik-virtru
dmihalcik-virtru requested review from a team as code owners July 7, 2026 15:30
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49fa2f99-fc2b-4019-a89b-6dca37f7f22d

📥 Commits

Reviewing files that changed from the base of the PR and between ff0dd58 and 16cd0eb.

📒 Files selected for processing (1)
  • xtest/sdk/java/cli.sh

📝 Walkthrough

Walkthrough

A new mechanism-mlkem case was added to the supports feature dispatch in the Java SDK CLI test script, which checks for mlkem:768 support by grepping the output of cmdline.jar help encrypt and returns the grep command's exit status.

Changes

ML-KEM Support Detection

Layer / File(s) Summary
Add mechanism-mlkem support check
xtest/sdk/java/cli.sh
Adds a new branch under supports that greps cmdline.jar help encrypt output for mlkem:768 (case-insensitive) and exits with the grep status.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • opentdf/tests#531: Modifies the same supports dispatch in cli.sh to add ML-KEM feature recognition via a similar cmdline.jar help encrypt check.
  • opentdf/tests#538: Adds the identical mechanism-mlkem dispatch branch checking for mlkem:768 in cli.sh.
  • opentdf/tests#540: Removes the same mechanism-mlkem dispatch logic that this PR adds to cli.sh.

Suggested reviewers: sujankota

Poem

A hop, a grep, a tiny check,
mlkem:768 upon the deck,
Encrypt help text now bears the clue,
Support confirmed with status true,
This rabbit thumps in code review! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: restoring Java SDK MLKEM feature support in xtest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-540-disable-pure-mlkem-java-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the 'mechanism-mlkem' mechanism in the Java CLI test script (xtest/sdk/java/cli.sh) by executing the command-line tool and checking for 'mlkem:768' in the help output. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant