chore: support multiple KAOs from the same KAS (DSPX-3780)#969
chore: support multiple KAOs from the same KAS (DSPX-3780)#969ntrevino-virtru wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TDF decryption process to support multiple Key Access Objects (KAOs) for the same split ID on the same Key Access Server (KAS). Instead of throwing an error on duplicate KAS URLs, splitLookupTableFactory now returns an array of KAOs as alternative options, and unwrapKey is updated to handle these alternatives. Unit and integration tests have been added and updated to verify this behavior, and fetch stubs were added to client wrapper tests to prevent network errors. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
X-Test Failure Report✅ js@main-main |
1 similar comment
X-Test Failure Report✅ js@main-main |
4789b3a to
4fe5ef5
Compare
|
1 participant
No description provided.