Skip to content

[Fix] DNS resources NL region fix #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

[Fix] DNS resources NL region fix #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1718649
[Fix] public zones in nl
anton-sidelnikov Jan 15, 2025
a634801
[Fix] rework of all dns resources to make it works within nl region
anton-sidelnikov Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion opentelekomcloud/acceptance/dns/data_source_opentelekomcloud_dns_nameservers_v2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@ const dataDNSNameserverName = "data.opentelekomcloud_dns_nameservers_v2.nameserv

func TestAccDNSV2NameserverDataSource_basic(t *testing.T) {
zoneName := randomZoneName()
dc := common.InitDataSourceCheck(dataZoneName)

resource.Test(t, resource.TestCase{
PreCheck: func() { common.TestAccPreCheckRequiredEnvVars(t) },
ProviderFactories: common.TestAccProviderFactories,
CheckDestroy: testAccCheckDNSV2ZoneDestroy,
CheckDestroy: dc.CheckResourceDestroy(),
Steps: []resource.TestStep{
{
Config: testAccDNSV2NameserverDataSource_nameserver(zoneName),
Expand Down
11 changes: 7 additions & 4 deletions opentelekomcloud/acceptance/dns/data_source_opentelekomcloud_dns_zone_v2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

"github.com/opentelekomcloud/terraform-provider-opentelekomcloud/opentelekomcloud/acceptance/common"
)

Expand All @@ -16,18 +15,20 @@ const dataZoneName = "data.opentelekomcloud_dns_zone_v2.z1"
func TestAccOpenStackDNSZoneV2DataSource_basic(t *testing.T) {
zone := randomZoneName()
randZoneTag := fmt.Sprintf("value-%s", acctest.RandString(5))
dc := common.InitDataSourceCheck(dataZoneName)

resource.Test(t, resource.TestCase{
PreCheck: func() { common.TestAccPreCheckRequiredEnvVars(t) },
ProviderFactories: common.TestAccProviderFactories,
CheckDestroy: testAccCheckDNSV2ZoneDestroy,
CheckDestroy: dc.CheckResourceDestroy(),
Steps: []resource.TestStep{
{
Config: testAccOpenStackDNSZoneV2DataSourceZone(zone, randZoneTag),
},
{
Config: testAccOpenStackDNSZoneV2DataSourceBasic(zone, randZoneTag),
Check: resource.ComposeTestCheckFunc(
dc.CheckResourceExists(),
testAccCheckDNSZoneV2DataSourceID(dataZoneName),
resource.TestCheckResourceAttr(dataZoneName, "name", zone),
resource.TestCheckResourceAttr(dataZoneName, "ttl", "3000"),
Expand All @@ -45,11 +46,12 @@ func TestAccOpenStackDNSZoneV2DataSource_byTag(t *testing.T) {
zone1 := randomZoneName()
zone2 := randomZoneName()
randZoneTag := fmt.Sprintf("value-%s", acctest.RandString(5))
dc := common.InitDataSourceCheck(dataZoneName)

resource.Test(t, resource.TestCase{
PreCheck: func() { common.TestAccPreCheckRequiredEnvVars(t) },
ProviderFactories: common.TestAccProviderFactories,
CheckDestroy: testAccCheckDNSV2ZoneDestroy,
CheckDestroy: dc.CheckResourceDestroy(),
Steps: []resource.TestStep{
{
Config: testAccOpenStackDNSZoneV2DataSourceZone2(zone1, zone2, randZoneTag),
Expand All @@ -66,11 +68,12 @@ func TestAccOpenStackDNSZoneV2DataSource_byTag(t *testing.T) {

func TestAccOpenStackDNSZoneV2DataSource_private(t *testing.T) {
zone1 := randomZoneName()
dc := common.InitDataSourceCheck(dataZoneName)

resource.Test(t, resource.TestCase{
PreCheck: func() { common.TestAccPreCheckRequiredEnvVars(t) },
ProviderFactories: common.TestAccProviderFactories,
CheckDestroy: testAccCheckDNSV2ZoneDestroy,
CheckDestroy: dc.CheckResourceDestroy(),
Steps: []resource.TestStep{
{
Config: testAccDNSV2ZonePrivate(zone1),
Expand Down
29 changes: 0 additions & 29 deletions opentelekomcloud/acceptance/dns/import_opentelekomcloud_dns_recordset_v2_test.go
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions opentelekomcloud/acceptance/dns/import_opentelekomcloud_dns_zone_v2_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading