Skip to content

[ci] Update PR validation workflow - #161

Merged
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow
Jul 31, 2026
Merged

[ci] Update PR validation workflow#161
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines and OpenWISP Anti AI Spam Policy.
  • N/A. This GitHub Actions caller-workflow change has no local manual execution path.
  • N/A. No application code changed.
  • N/A. No user-facing behavior or documentation changed.

Reference to Existing Issue

Related to openwisp/openwisp-utils#716

Description of Changes

Adds edited and ready_for_review pull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.

Screenshot

N/A. This is a GitHub Actions workflow-only change.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dc57a49b-7a69-4618-ab00-d06f0fd3ce47

📥 Commits

Reviewing files that changed from the base of the PR and between e417bcd and c0fdbf0.

📒 Files selected for processing (1)
  • .github/workflows/bot-autoassign-pr-issue-link.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Kilo Code Review
🧰 Additional context used
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml

[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)


[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (2)
.github/workflows/bot-autoassign-pr-issue-link.yml (2)

4-4: 🔒 Security & Privacy

Verify the new privileged trigger behavior.

Line 4 now causes the issue_assignment reusable workflow to run for every PR edit and draft-to-ready transition. Confirm that it is idempotent for these events and does not interpolate editable PR fields into shell commands; otherwise, repeated user-controlled edits could trigger unintended privileged side effects.


9-10: LGTM!


📝 Walkthrough

Walkthrough

The pull request workflow now triggers for edited and ready_for_review activities in addition to its existing pull request events. Its concurrency group is keyed only by repository and pull request number, so runs for different actions on the same pull request share one concurrency scope. Existing workflow permissions remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title is descriptive, uses the required [ci] prefix, and matches the workflow validation changes.
Description check ✅ Passed The description clearly matches the GitHub Actions workflow changes and linked issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed Workflow-only GitHub Actions change; regression tests are impractical and excluded by the stated exception.
Features ✅ Passed PASS: This is a workflow-only change (PR event triggers/concurrency); no feature, UI, docs, or app code is affected, so the feature checklist is not applicable.
Changes ✅ Passed Workflow-only CI change; no docs, UI, or public APIs were affected, and there’s no local test path to update.
General Rules ✅ Passed Workflow-only change; trigger/concurrency tweak is compact, consistent, and shows no obvious security, perf, docs, or test issues.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/update-pr-validation-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nemesifier
nemesifier merged commit fc32015 into master Jul 31, 2026
10 of 11 checks passed
@nemesifier
nemesifier deleted the ci/update-pr-validation-workflow branch July 31, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant