Skip to content

[ci] Update PR validation workflow - #403

Merged
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow
Jul 31, 2026
Merged

[ci] Update PR validation workflow#403
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines and OpenWISP Anti AI Spam Policy.
  • N/A. This GitHub Actions caller-workflow change has no local manual execution path.
  • N/A. No application code changed.
  • N/A. No user-facing behavior or documentation changed.

Reference to Existing Issue

Related to openwisp/openwisp-utils#716

Description of Changes

Adds edited and ready_for_review pull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.

Screenshot

N/A. This is a GitHub Actions workflow-only change.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4feb4d85-442d-4267-9475-68e1eb457aed

📥 Commits

Reviewing files that changed from the base of the PR and between 9de63c4 and eab1e14.

📒 Files selected for processing (1)
  • .github/workflows/bot-autoassign-pr-issue-link.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Kilo Code Review
🧰 Additional context used
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml

[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)


[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (2)
.github/workflows/bot-autoassign-pr-issue-link.yml (2)

4-4: LGTM!

Also applies to: 9-10


5-8: 🔒 Security & Privacy

Keep the minimum permissions needed by the reusable workflow.

This single-job, pull_request_target workflow only calls reusable-bot-autoassign.yml, so workflow-scoped issues: write correctly acts as the caller’s permission envelope here; there is no separate job to narrow further. Also note that using @master for a reusable workflow is a separate risk because it can acquire new permissions code at any time.

			> Likely an incorrect or invalid review comment.

📝 Walkthrough

Walkthrough

The pull request automation workflow now triggers for opened, reopened, closed, edited, and ready_for_review events. Its concurrency group is keyed by repository and pull request number, without including the triggering event action.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title is descriptive, uses the required [ci] type, and matches the workflow validation changes.
Description check ✅ Passed The description covers the template sections and change details, but it does not close a specific issue with the required Closes # format.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed Workflow-only GitHub Actions change; valid exception applies, so no regression test is required.
Features ✅ Passed PASS: This PR only changes a GitHub Actions workflow; no feature/UI code, docs, or tests were added, so the feature-request checklist is not applicable.
Changes ✅ Passed PASS: workflow-only change; no UI/docs/tests/public API impact detected, and PR marked screenshots/tests as N/A.
General Rules ✅ Passed PASS: This is a small workflow-only change; no obvious security, performance, naming, comment, or AGENTS.md issues were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/update-pr-validation-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nemesifier
nemesifier merged commit d8a187d into master Jul 31, 2026
13 of 14 checks passed
@nemesifier
nemesifier deleted the ci/update-pr-validation-workflow branch July 31, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant