Skip to content

[ci] Update PR validation workflow - #582

Merged
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow
Jul 31, 2026
Merged

[ci] Update PR validation workflow#582
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines and OpenWISP Anti AI Spam Policy.
  • N/A. This GitHub Actions caller-workflow change has no local manual execution path.
  • N/A. No application code changed.
  • N/A. No user-facing behavior or documentation changed.

Reference to Existing Issue

Related to openwisp/openwisp-utils#716

Description of Changes

Adds edited and ready_for_review pull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.

Screenshot

N/A. This is a GitHub Actions workflow-only change.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4ac52a18-3e0e-4dae-8d54-9c72c7e7cd70

📥 Commits

Reviewing files that changed from the base of the PR and between 8802194 and 44111bf.

📒 Files selected for processing (1)
  • .github/workflows/bot-autoassign-pr-issue-link.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Kilo Code Review
🧰 Additional context used
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml

[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)


[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (2)
.github/workflows/bot-autoassign-pr-issue-link.yml (2)

4-4: 🔒 Security & Privacy

Verify the expanded privileged trigger surface.

Adding edited and ready_for_review causes this pull_request_target workflow to run for additional PR-controlled events while retaining issues: write and passing bot credentials to the reusable workflow. Confirm that reusable-bot-autoassign.yml does not interpolate PR-controlled fields into shell commands or other privileged operations; otherwise, gate these events or harden the downstream input handling. (docs.github.com)


9-10: LGTM!


📝 Walkthrough

Walkthrough

The pull request workflow now runs for edited and ready_for_review events in addition to its existing events. Its concurrency group no longer includes the event action, grouping runs by repository and pull request number.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title is descriptive, uses the required [ci] type, and matches the workflow validation changes.
Description check ✅ Passed The description follows the template sections and covers the checklist, change summary, and screenshot notes, though the issue reference is not in the expected format.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed Workflow-only GitHub Actions change; regression tests are impractical here and no core user-facing functionality changed.
Features ✅ Passed Workflow-only PR; no product feature is added, so the feature-request issue/docs/tests/screenshot requirements are not applicable.
Changes ✅ Passed Workflow-only GitHub Actions change; no docs/UI/app code affected, and tests/screenshots aren't applicable here.
General Rules ✅ Passed Only workflow trigger/concurrency updates; no new code paths, docs, or tests needed, and no obvious security/perf/style issues found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/update-pr-validation-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nemesifier
nemesifier merged commit afec653 into master Jul 31, 2026
12 of 13 checks passed
@nemesifier
nemesifier deleted the ci/update-pr-validation-workflow branch July 31, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant