Skip to content

[ci] Update PR validation workflow - #494

Merged
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow
Jul 31, 2026
Merged

[ci] Update PR validation workflow#494
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow

Conversation

@nemesifier

@nemesifier nemesifier commented Jul 29, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines and OpenWISP Anti AI Spam Policy.
  • N/A. This GitHub Actions caller-workflow change has no local manual execution path.
  • N/A. No application code changed.
  • N/A. No user-facing behavior or documentation changed.

Reference to Existing Issue

Related to openwisp/openwisp-utils#716

Description of Changes

Adds edited and ready_for_review pull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.

Screenshot

N/A. This is a GitHub Actions workflow-only change.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request workflow now handles edited and ready_for_review events in addition to its existing pull request triggers. Its concurrency group now identifies runs by repository and pull request number, regardless of the triggering action.

Estimated code review effort: 1 (Trivial) | ~2 minutes


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
General Rules ❌ Error Top-level issues: write remains on a pull_request_target workflow, so the write token is broader than needed and still a potential security risk. Move issues: write to the single reusable job (or remove it if the App token already covers the action) and keep workflow-level permissions read-only.
Features ⚠️ Warning Issue #709 was validated/accepted, but this patch only changes the workflow file; it adds no docs update or tests for the new PR-validation behavior. citeturn0view1turn0view3 Update the docs for the PR-validation workflow and add automated tests or another verifiable check; the current change is workflow-only.
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed Workflow-only change in GitHub Actions; bug-fix test requirements are exempt for workflow fixes, so no regression test is needed.
Changes ✅ Passed Workflow-only change; no UI, docs, or public API impact, and no breaking migration issue is evident.
Title check ✅ Passed The title is descriptive, uses the required [ci] type, and matches the workflow validation changes.
Description check ✅ Passed The description follows the template closely, covering checklist items, issue reference, changes, and screenshots.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/update-pr-validation-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kilo-code-bot

kilo-code-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/bot-autoassign-pr-issue-link.yml

Reviewed by step-3.7-flash · Input: 70.6K · Output: 11K · Cached: 93.4K

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/bot-autoassign-pr-issue-link.yml:
- Line 7: Move the issues: write permission from workflow scope into the
auto-assign-issue job, provided the reusable workflow supports job-level
permissions. Confirm the reusable workflow contract and document the specific
issue-assignment write operation it requires, while preventing unrelated future
jobs from inheriting this permission.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2a6277d9-9e41-41f5-9ad2-36bed14b45ae

📥 Commits

Reviewing files that changed from the base of the PR and between b82ffcd and 835957c.

📒 Files selected for processing (1)
  • .github/workflows/bot-autoassign-pr-issue-link.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Kilo Code Review
🧰 Additional context used
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml

[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)


[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (1)
.github/workflows/bot-autoassign-pr-issue-link.yml (1)

4-4: LGTM!

Also applies to: 9-10

Comment thread .github/workflows/bot-autoassign-pr-issue-link.yml
@nemesifier

Copy link
Copy Markdown
Member Author

@coderabbitai resolve

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved and changes approved.

@nemesifier
nemesifier merged commit 9a721d0 into master Jul 31, 2026
28 checks passed
@nemesifier
nemesifier deleted the ci/update-pr-validation-workflow branch July 31, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant