[ci] Update PR validation workflow - #760
Conversation
📝 WalkthroughWalkthroughThe bot workflow now triggers for Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by ling-3.0-flash-free · Input: 21K · Output: 10.9K · Cached: 199.4K |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/bot-autoassign-pr-issue-link.yml:
- Around line 5-8: Move the workflow-level permissions block into the
auto-assign-issue job as jobs.auto-assign-issue.permissions, preserving
contents: read, issues: write, and pull-requests: read so only the
reusable-workflow caller job receives these permissions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b16a1168-da7d-4f32-aafb-e9075996d791
📒 Files selected for processing (1)
.github/workflows/bot-autoassign-pr-issue-link.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Analyze (actions)
- GitHub Check: Kilo Code Review
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-03-06T08:47:54.428Z
Learnt from: stktyagi
Repo: openwisp/openwisp-radius PR: 689
File: .github/workflows/bot-ci-failure.yml:60-60
Timestamp: 2026-03-06T08:47:54.428Z
Learning: In openwisp/openwisp-radius and similar OpenWISP repos, reusable workflow caller files intentionally reference upstream reusable workflows with master (e.g., openwisp/openwisp-utils/.github/workflows/reusable-bot-ci-failure.ymlmaster). This is by design to ensure callers always use the latest changes from the master branch of the upstream project. Do not flag such references as security or pinning issues during code reviews. If applying this pattern broadly, treat any workflow call that uses a remote reusable workflow from a different repository with master as an intentional design choice rather than a vulnerability.
Applied to files:
.github/workflows/bot-autoassign-pr-issue-link.yml
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml
[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level
(excessive-permissions)
[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment
(undocumented-permissions)
🔇 Additional comments (2)
.github/workflows/bot-autoassign-pr-issue-link.yml (2)
4-4: LGTM!
9-10: 🩺 Stability & Availabilityno change needed.
cancel-in-progress: trueis already set, so newer runs in this PR-specific concurrency group cancel in-progress validation runs.> Likely an incorrect or invalid review comment.
|
@coderabbitai resolve |
✅ Action performedComments resolved and changes approved. |
Checklist
Reference to Existing Issue
Related to openwisp/openwisp-utils#716
Description of Changes
Adds
editedandready_for_reviewpull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.Screenshot
N/A. This is a GitHub Actions workflow-only change.