Repository navigation
Re-enable test_indexing_item_not_front and cover non-front items - #400
Merged
Merged
Conversation
The test was skipped because its comments described libzim behavior that no longer holds: with libzim 3.13 a non-front item gets no suggestions at all, while full-text search still finds it. As agreed in the issue, treat libzim's current behavior as the spec. Assert it in the re-enabled test and add two tests for a non-front text/html item, one with custom IndexData and one indexed by libzim itself.
mcwanza
marked this pull request as ready for review
November 9, 2026 16:37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2947 2947
Branches 452 452
=========================================
Hits 2947 2947 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_indexing_item_not_frontwas skipped since libzim stopped matching what it asserted. It is re-enabled and now asserts what libzim 3.13 does: a non-front item gets no suggestions, but itsIndexDatacontent and title are still found by full-text search.test_indexing_html_not_front_custom: a non-fronttext/htmlitem with customIndexDatabehaves the same way.test_indexing_html_not_front_with_libzim: a non-fronttext/htmlitem withoutIndexDatais indexed by libzim itself, from the document body and the item title rather than the<title>tag.### Changedentry to the changelog.Fixes #258