Skip to content

Revert "feat(ci): auto-bump recall floors after stable releases" (#2162) - #2166

Merged
carlos-alm merged 1 commit into
mainfrom
revert/2162-recall-floors
Jul 29, 2026
Merged

Revert "feat(ci): auto-bump recall floors after stable releases" (#2162)#2166
carlos-alm merged 1 commit into
mainfrom
revert/2162-recall-floors

Conversation

@carlos-alm

Copy link
Copy Markdown
Contributor

Summary

Reverts #2162. That PR was merged without checking Greptile's review — it has a Confidence Score of 2/5 with 3 real, unaddressed findings:

  1. The workflow's trigger condition admits scheduled Publish runs, which don't produce a benchmark artifact, so the workflow fails on every scheduled run.
  2. Version/release identity can drift: an older workflow_dispatch retry finishing after a newer release tag exists would mislabel and force-push older benchmark metrics onto the newer release's branch.
  3. The language key is interpolated unescaped into a regular expression — a future language key containing regex metacharacters would fail to match or match the wrong text.

This PR only reverts; it does not merge itself. A follow-up PR fixing all three issues will be opened separately once ready.

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Reverts the recall-floor auto-update feature:

  • Removes the post-publish GitHub Actions workflow.
  • Removes the script that raised per-language benchmark thresholds.

Confidence Score: 5/5

The revert appears safe to merge with no actionable issues identified.

The deleted workflow and script were self-contained additions, and no remaining repository callers or configuration depend on either file.

Important Files Changed

Filename Overview
.github/workflows/update-recall-floors.yml Cleanly removes the self-contained post-publish recall-floor workflow without leaving repository references.
scripts/update-recall-floors.mjs Cleanly removes the threshold-update script; no remaining tests, workflows, or package scripts invoke it.

Reviews (1): Last reviewed commit: "Revert "feat(ci): auto-bump recall floor..." | Re-trigger Greptile

@carlos-alm
carlos-alm merged commit 599df2c into main Jul 29, 2026
25 checks passed
@carlos-alm
carlos-alm deleted the revert/2162-recall-floors branch July 29, 2026 00:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant