[GR-36894] Add DynamicObject nodes. #12238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
7 times, most recently
from
69cd581 to
47974e6
Compare
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
7 times, most recently
from
d51a949 to
ea83644
Compare
graalvmbot
changed the title
graalvmbot
changed the title
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
8 times, most recently
from
6bb2dee to
064123a
Compare
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
3 times, most recently
from
a0b2219 to
82fbf5c
Compare
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
from
82fbf5c to
3dffe98
Compare
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
from
4b9b34f to
49e57bc
Compare
* Move index, field info, and final assumption to Location base class. * Merge array and field location classes. * Add non-virtual Location.canStoreValue(). * Add non-virtual Location.get and set methods. * Make isAssumedFinal() and isConstant() non-virtual. * Add exact-type fast path for type.isInstance(value). * Remove internal location interfaces. * Relax assertion in Move.compareTo.
* Remove cached mode; check if the property flags match the expected flags according to mode. * Check oldShape valid assumption in specialization and update shape if newShape is obsolete.
Ensure extension arrays are seen as non-null in host compilation, too. Remove DynamicField annotation from the array fields to not needlessly mark them as unsafe-accessed.
Remove unused method: getOwningMap.
graalvmbot
force-pushed
the
bd/GR-36894-dynamicobjectnodes
branch
from
49e57bc to
4a0cc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: Introduce a new
Node-based API for dealing withDynamicObject, as a more lightweight replacement forDynamicObjectLibrary.