Skip to content

Remove input invalid event listener during destroy #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leighhalliday wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove input invalid event listener during destroy #954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/tom-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,12 +377,21 @@ export default class TomSelect extends MicroPlugin(MicroEvent){
}
};

const input_invalid = () => {
if( self.isValid ){
self.isValid = false;
self.isInvalid = true;
self.refreshState();
}
}

addEvent(input,'invalid', input_invalid);
addEvent(document,'mousedown', doc_mousedown);
addEvent(window,'scroll', win_scroll, passive_event);
addEvent(window,'resize', win_scroll, passive_event);

this._destroy = () => {
input.removeEventListener('invalid',input_invalid);
document.removeEventListener('mousedown',doc_mousedown);
window.removeEventListener('scroll',win_scroll);
window.removeEventListener('resize',win_scroll);
Expand All @@ -405,14 +414,6 @@ export default class TomSelect extends MicroPlugin(MicroEvent){
delete settings.optgroups;
delete settings.options;

addEvent(input,'invalid', () => {
if( self.isValid ){
self.isValid = false;
self.isInvalid = true;
self.refreshState();
}
});

self.refreshItems();
self.close(false);
self.inputState();
Expand Down Expand Up @@ -765,15 +766,15 @@ export default class TomSelect extends MicroPlugin(MicroEvent){
*
*/
onInput(e:MouseEvent|KeyboardEvent):void {

Copy link
Author

@leighhalliday leighhalliday Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh sorry, editor is removing trailing whitespace :(

if( this.isLocked ){
return;
}

const value = this.inputValue();
if( this.lastValue === value ) return;
this.lastValue = value;

if( value == '' ){
this._onInput();
return;
Expand Down Expand Up @@ -1455,14 +1456,14 @@ export default class TomSelect extends MicroPlugin(MicroEvent){

optgroup = option[self.settings.optgroupField] || '';
optgroups = Array.isArray(optgroup) ? optgroup : [optgroup];


for (j = 0, k = optgroups && optgroups.length; j < k; j++) {
optgroup = optgroups[j];

let order = option.$order;
let self_optgroup = self.optgroups[optgroup];
if( self_optgroup === undefined ){
if( self_optgroup === undefined ){
optgroup = '';
}else{
order = self_optgroup.$order;
Expand All @@ -1485,8 +1486,8 @@ export default class TomSelect extends MicroPlugin(MicroEvent){
active_option = option_el;
}
}
}
}

group_fragment.appendChild(option_el);
if( optgroup != '' ){
groups[optgroup] = group_order_i;
Expand Down