Adjust Twine format to OrganicsMaps usages #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Borsuk <[email protected]>
Xcode didn't parse XML files started with a comment line Signed-off-by: Alexander Borsuk <[email protected]>
* Added regional dialect fallback to generic language Signed-off-by: David Martinez <[email protected]> * Reorder generic_language to mantain fallback_mapping priority Signed-off-by: David Martinez <[email protected]> * Update lib/twine/output_processor.rb Signed-off-by: David Martinez <[email protected]> Co-authored-by: Alexander Borsuk <[email protected]> Co-authored-by: Alexander Borsuk <[email protected]>
Signed-off-by: David Martinez <[email protected]>
Merge branch 'main' into organicmaps
Signed-off-by: Alexander Borsuk <[email protected]>
Signed-off-by: Alexander Borsuk <[email protected]>
Fixed jquery json language extraction and updated to the latest Twine
It creates a lot of unnecessary noise after upgrading Twine Signed-off-by: Alexander Borsuk <[email protected]>
Signed-off-by: Alexander Borsuk <[email protected]>
Instead of alphabetical, sort these in the expect CLDR order zero...other Only sort when retreiving the values for formatter consumption, this should leave Twine files in their default order. Signed-off-by: Dwayne Bailey <[email protected]>
Indent with 4 spaces and fix the broken plural \t\s*2 indentation
2*sp -> \t Remove the confusingly named tab() that indents with spaces and use \t directly
This aligns with current OrganicMaps structure of: comment = tag = en =
allows: en = en-GB = before alphabetical sorting Aligns with existing and is more logical
OrganicMaps: comment = tags = ref = dev-LANG = other-LANG = Twine original: dev-LANG = ref = tags = comment = other-LANG = fix
|
Do I understand it right that this change is needed to generate Twine/OM strings files from existing android or ios localization files (or other twine-supported formats)? ATM we don't use this conversion at all, only the opposite (from Twine/OM to native platform localizations). Is there some idea to use e.g. Android -> Twine conversion? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjust the Twine output format to align with the existing Twine strings.txt in OM
Changes:
Problems: