-
-
Notifications
You must be signed in to change notification settings - Fork 507
Convert to ESM #2460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to ESM #2460
Conversation
|
Yeah this should be an 8.0 feature I think? |
|
I just read through that post and it seems a lot of users have concerns moving to ESM. I know in my life it's been a nightmare working on a few different open source react projects. |
I could be wrong. But Orval is a CLI tool, it doesn't integrate directly with the project it's being used in. There are no changes to the output. So I don't understand what the concern is 😃 But I might have missed something. The only breaking change, I'm aware of, are the user provided mutators and hooks must be ESM now. |
|
yeah the mutators etc being ESM to me is a bigger change than one might think but I could be wrong. People were mad about uprgading to Node 22 and that should have been harmless! |
to be fair that breaking change wasn't released as a major. I'd probably also get slightly upset if that happened to me 😄 |
|
Yep that was my fault! Also i think i just caused you a merge conflict |
|
I will release 7.15.0 tomorrow and then merge this and the docs one as 8.0.0! |
* chore: update deps * feat: orval is now pure ESM * fixes error in test * fixes odd path issue on CI * fix outdated lock file
Packages now compiles to ESM. No more CommonJS. Users needing CommonJS should stay on the previous version.
Updated a bunch of packages that was stuck on old versions as they moved to pure ESM and we couldn't use them. But now we can.
Related:
Breaking changes:
For TypeScript users there's no changes