Conversation
vinckr
left a comment
vinckr
left a comment
There was a problem hiding this comment.
love it ❤️
just a few changes, then merge it
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
|
These two need to be merged: |
|
Once merged I would add a notice to the older next js guide that we recommend using next auth instead as the integration is better than with the ory/integrations package. We should probably de-list the old next-js guide when we do that. |
|
I think we should go back to this and fix it up! |
aeneasr
force-pushed
the
add-nextjs-next
branch
from
1a7a4b0 to
8fbdcbf
Compare
|
Ok, I updated the guide for auth.js v5 and it's working wonderfully now. |
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the documentation by adding a guide for NextAuth integration. The key changes include a minor text update in the CodeFromRemote component and an updated ordering of sidebar documentation links for various authentication integrations.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/theme/CodeFromRemote.tsx | Updated the anchor text to "See full code on GitHub" to improve text clarity. |
| src/sidebar.ts | Reordered guide links to add "auth-js" and "nextjs" while moving "expressjs" for better navigation. |
Files not reviewed (1)
- docs/getting-started/integrate-auth/14_auth-js.mdx: Language not supported
|
This guide does not need upstream changes to auth.js. |
vinckr
left a comment
vinckr
left a comment
There was a problem hiding this comment.
love it ❤️
did not test the example e2e, otherwise looks good to merge to me!
|
I did test it :) |
2 participants
This pull request enhances the documentation by adding a guide for NextAuth integration. The key changes include a minor text update in the CodeFromRemote component and an updated ordering of sidebar documentation links for various authentication integrations.