improving performance of the fuzzy function by having a state#35
Open
julochrobak wants to merge 1 commit intoostap:masterfrom
Open
improving performance of the fuzzy function by having a state#35julochrobak wants to merge 1 commit intoostap:masterfrom
julochrobak wants to merge 1 commit intoostap:masterfrom
Conversation
Owner
|
As tempting as it looks, I would rather not introduce the State property for the sake of performance. It has been a while, but if you are still interested in optimizing the approximate string matching, there is a different way to approach it. Instead of using for j := 1; j < n; j++ {
for i := 1; i < m; i++ {
if s[i-1] == t[j-1] {
d[i][j] = d[i-1][j-1] // no operation required
} else {
d[i][j] = min(
d[i-1][j]+1, // a deletion
d[i][j-1]+1, // an insertion
d[i-1][j-1]+1) // a substitution
}
}
}Note that the indexes only go back as far as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the performance of the fuzzy function by avoiding allocation of the matrix on each call. In other words, there is a matrix allocated on the first call and reused on the following calls. If bigger matrix is required it is recreated.
In order to allow parallel execution we cannot use a single global variable to store the matrix. I've introduced a State property to the Func structure which allows every function to have a state and reuse it among the calls.
Another small performance improvement is to use own min/max function and avoid the built-in Min/Max on floats.