Support running with --enable=frozen-string-literal #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apps that run with --enable=frozen-string-literal we can get a FrozenError. Using String.new instead of '' fixes that without breaking it for anyone else. When running the specs with frozen strings (RUBYOPT="--enable=frozen-string-literal" rake), there were three files that generate errors. I added the magic comment: # frozen-string-literal: false to those to work both ways. I have a related PR on http-2 to get all the specs passing: igrigorik/http-2#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In apps that run with
--enable=frozen-string-literalwe can get aFrozenError.Using
String.newinstead of''fixes that without breaking it for anyone else.When running the specs with frozen strings (
RUBYOPT="--enable=frozen-string-literal" rake), there were three test files that also generate errors. I added the magic comment:# frozen-string-literal: falseto those to work both ways.
I have a related PR on
http-2to get all the specs passing: igrigorik/http-2#161