Fix stack precommit crash on Windows #25891
Conversation
|
Updated 6:01 PM PT - Jan 8th, 2026
❌ @sosukesuzuki, your commit b7d5d33 has 5 failures in
🧪 To try this PR locally: bunx bun-pr 25891That installs a local version of the PR into your bun-25891 --bun |
WalkthroughUpdates the default WebKit version in CMake configuration from commit hash Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmake/tools/SetupWebKit.cmake (1)
1-6: Consider using a CACHE STRING forWEBKIT_VERSIONinstead ofoption()(BOOL) to avoid surprising-DWEBKIT_VERSION=<hash>behavior.
This is configuration hygiene and makes the CMake cache/UI reflect the actual intent (a commit hash string).Proposed change
-option(WEBKIT_VERSION "The version of WebKit to use") +set(WEBKIT_VERSION "" CACHE STRING "The version of WebKit to use (e.g. a commit hash)") option(WEBKIT_LOCAL "If a local version of WebKit should be used instead of downloading") if(NOT WEBKIT_VERSION) set(WEBKIT_VERSION 1d0216219a3c52cb85195f48f19ba7d5db747ff7) endif()
🤖 Fix all issues with AI agents
In @cmake/tools/SetupWebKit.cmake:
- Around line 4-6: The WEBKIT_VERSION bump in SetupWebKit.cmake references
release autobuild-1d0216219a3c52cb85195f48f19ba7d5db747ff7 but the Windows ARM64
asset (bun-webkit-windows-arm64.tar.gz) is missing; either publish that asset to
the release or update the build/configuration to explicitly skip Windows ARM64.
Locate the WEBKIT_VERSION usage in SetupWebKit.cmake and: 1) if Windows ARM64 is
supported, ensure the release contains bun-webkit-windows-arm64.tar.gz and
update any download lists to include it; or 2) if not supported, add/adjust
platform filtering logic and documentation to exclude windows-arm64 (and make
any CI/build scripts that enumerate artifacts skip that platform). Also run or
request a macOS aarch64 integration test
(test/integration/next-pages/test/dev-server.test.ts) against this commit before
merging to confirm no regressions.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
cmake/tools/SetupWebKit.cmake
| if(NOT WEBKIT_VERSION) | ||
| set(WEBKIT_VERSION 863778130931e0081a688f48e8479b8ee61b9507) | ||
| set(WEBKIT_VERSION 1d0216219a3c52cb85195f48f19ba7d5db747ff7) | ||
| endif() |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
WEBKIT_VERSION="1d0216219a3c52cb85195f48f19ba7d5db747ff7"
TAG="autobuild-${WEBKIT_VERSION}"
# 1) Check if the tag exists and list asset names
echo "=== Checking release tag: ${TAG} ==="
gh api "repos/oven-sh/WebKit/releases/tags/${TAG}" --jq '
"tag=\(.tag_name)\nassets=\n" + (.assets | sort_by(.name) | map(" - " + .name) | join("\n"))
' 2>&1 || {
echo "ERROR: Unable to fetch release info. Tag may not exist or API call failed."
exit 1
}
# 2) Quick sanity check: ensure at least the "base" triplet assets exist.
echo ""
echo "=== Checking for expected assets ==="
EXPECTED=(
"bun-webkit-windows-amd64.tar.gz"
"bun-webkit-windows-arm64.tar.gz"
"bun-webkit-macos-amd64.tar.gz"
"bun-webkit-macos-arm64.tar.gz"
"bun-webkit-linux-amd64.tar.gz"
"bun-webkit-linux-arm64.tar.gz"
)
ASSETS="$(gh api "repos/oven-sh/WebKit/releases/tags/${TAG}" --jq '.assets[].name' 2>&1 || echo "")"
if [ -z "$ASSETS" ]; then
echo "ERROR: Could not retrieve asset list."
exit 1
fi
missing=0
for e in "${EXPECTED[@]}"; do
if echo "$ASSETS" | grep -qxF "$e"; then
echo "✓ Found: $e"
else
echo "✗ MISSING: $e"
missing=$((missing+1))
fi
done
if [ $missing -gt 0 ]; then
echo ""
echo "WARNING: $missing expected assets are missing from the release."
exit 1
else
echo ""
echo "SUCCESS: All expected assets are present."
exit 0
fiRepository: oven-sh/bun
Length of output: 1466
Verify Windows ARM64 asset availability and update release or build configuration.
The release autobuild-1d0216219a3c52cb85195f48f19ba7d5db747ff7 exists, but bun-webkit-windows-arm64.tar.gz is missing while Linux and macOS include both amd64 and arm64 variants. If Windows ARM64 is a supported build target, this will break downloads. Either publish the missing asset to the release or clarify in the build configuration that Windows ARM64 is not supported and adjust accordingly.
Also investigate whether the reported macOS aarch64 integration test failure (test/integration/next-pages/test/dev-server.test.ts) correlates with this WebKit bump; consider testing this commit on macOS aarch64 runners before merge.
🤖 Prompt for AI Agents
In @cmake/tools/SetupWebKit.cmake around lines 4 - 6, The WEBKIT_VERSION bump in
SetupWebKit.cmake references release
autobuild-1d0216219a3c52cb85195f48f19ba7d5db747ff7 but the Windows ARM64 asset
(bun-webkit-windows-arm64.tar.gz) is missing; either publish that asset to the
release or update the build/configuration to explicitly skip Windows ARM64.
Locate the WEBKIT_VERSION usage in SetupWebKit.cmake and: 1) if Windows ARM64 is
supported, ensure the release contains bun-webkit-windows-arm64.tar.gz and
update any download lists to include it; or 2) if not supported, add/adjust
platform filtering logic and documentation to exclude windows-arm64 (and make
any CI/build scripts that enumerate artifacts skip that platform). Also run or
request a macOS aarch64 integration test
(test/integration/next-pages/test/dev-server.test.ts) against this commit before
merging to confirm no regressions.
What does this PR do?
Attempt to fix stack precommit crash on Windows
oven-sh/WebKit#128
How did you verify your code works?