fix(lib/server): use the instance source in player.getState - #255
Open
DoluTattoo wants to merge 1 commit into
Open
fix(lib/server): use the instance source in player.getState#255DoluTattoo wants to merge 1 commit into
DoluTattoo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PlayerInterface.getStatereads the globalsourceinstead of the instance property:Looks like an oversight: the constructor already assigns
this.source, and every other method uses it. Whenever the instance is used outside of a handler for that same player,getStatereturns another player's state bag, and writes land on the wrong entity.Fix
lib/server/player.luaalready does this, andlib/server/vehicle.tsresolves its state bag fromthis.entity.Impact
No API change. Calls that were correct by accident keep working; the others now target the intended player.