Skip to content

docs: add ocis 8.0.6 release notes - #193

Merged
DeepDiver1975 merged 3 commits into
masterfrom
add_ocis_8.6.0_release_notes
Aug 3, 2026
Merged

docs: add ocis 8.0.6 release notes#193
DeepDiver1975 merged 3 commits into
masterfrom
add_ocis_8.6.0_release_notes

Conversation

@mmattel

@mmattel mmattel commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This PR will add the release notes for ocis 8.0.6

@mmattel
mmattel requested a review from kobergj July 16, 2026 09:35
@mmattel
mmattel requested a review from a team as a code owner July 16, 2026 09:35
@mmattel mmattel added the documentation Improvements or additions to documentation label Jul 16, 2026
@DeepDiver1975

Copy link
Copy Markdown
Member

Code Review: add ocis 8.0.6 release notes

Note: The PR description already flags this as a draft ("the current ones are just c/p and used as templates") — the findings below confirm the placeholder content and shouldn't merge as-is.

Blocking (correctness)

  • Both bullets are duplicated verbatim from the existing 8.0.5 section. The file already contains these identical entries under 8.0.5:

    • Security: Bump Go to 1.25.11: …/pull/12446[#12446]
    • Bugfix: Education user delete no longer 404s… …/pull/12395[#12395]

    These belong to 8.0.5; real 8.0.6 changes need to be substituted.

  • Version regression: 8.0.5 already reports "Bump Go to 1.25.11", so an 8.0.6 entry bumping Go to the same 1.25.11 is meaningless.

  • Reused PR reference #12446: in the 8.0.5 block #12446 is linked for both the Go bump and the libvips upgrade (a pre-existing copy-paste error), and the new 8.0.6 Go entry inherits that same likely-wrong link.

Style / conventions — all good

  • Section placement preserves descending-version order (8.1.0 → 8.0.6 → 8.0.5). ✓
  • Link formatting ({ocis-releases-url}/v8.0.6[…, window=_blank] and bare PR URLs) matches surrounding sections. ✓
  • [discrete] === Issues Fixed structure consistent with sibling patch sections. ✓

Non-blocking

  • Branch name typo: add_ocis_8.6.0_release_notes should be 8.0.6.
  • Docs-only, no CI/test concerns; a local asciidoctor/Antora build to confirm link rendering is worthwhile but nothing changes anchors/aliases.

Recommendation

Hold for revision — replace the two placeholder entries with the actual 8.0.6 changes and fix the #12446 reference. Structure, placement, and formatting are all correct and ready to receive the real content.

Comment thread modules/ROOT/pages/ocis_release_notes.adoc Outdated
@mmattel
mmattel marked this pull request as draft July 16, 2026 10:59
@mmattel

mmattel commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

This PR should be on draft because unfinished. Accidentially was not set to, set to draft now.

@mmattel
mmattel force-pushed the add_ocis_8.6.0_release_notes branch from 75bd1fd to 2a64c39 Compare August 3, 2026 08:34
@mmattel
mmattel marked this pull request as ready for review August 3, 2026 08:34
Comment thread modules/ROOT/pages/ocis_release_notes.adoc Outdated
@DeepDiver1975
DeepDiver1975 merged commit 7c3e45e into master Aug 3, 2026
2 checks passed
@DeepDiver1975
DeepDiver1975 deleted the add_ocis_8.6.0_release_notes branch August 3, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants