fix: bump reva to allow space managers to remove others' shares - #12705
Merged
mzner merged 2 commits intoAug 4, 2026
Merged
Conversation
Space managers with the RemoveGrant permission on a resource could not remove user shares created by other users; the share manager only allowed the share's creator to remove it. This bumps reva to the commit that fixes Unshare to also honor the RemoveGrant permission.
mzner
force-pushed
the
fix/OCISDEV-748/space-manager-cannot-remove-shares-created-by-other-users
branch
from
August 3, 2026 08:07
175e7cc to
3915487
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…o vet Bumping reva pulled in reva's go 1.26 requirement, and go 1.26's stricter printf vet analyzer now sees through the OcisLocale interface to flag gotext.Locale.Get as a printf-wrapper, breaking go test across 5 packages. Forwarding through func fields hides that static trail from vet.
2403905
requested changes
Aug 4, 2026
Contributor
Author
Could you please let me know how to do that? |
2403905
approved these changes
Aug 4, 2026
mzner
deleted the
fix/OCISDEV-748/space-manager-cannot-remove-shares-created-by-other-users
branch
August 4, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Space managers with the
RemoveGrantpermission on a resource were unable to remove shares created by other users. The removal failed with a generic HTTP 500 (generalexception: error removing share) instead of succeeding.The root cause was a permission mismatch between two layers of the sharing stack in reva:
GetShareand theRemoveSharegRPC handler both allow a user withRemoveGrant/ListGrantspermission on the resource to act on a share, butUnsharein the jsoncs3 share manager only allowed the share's creator to remove it. This is fixed upstream in owncloud/reva#687; this PR bumps the reva dependency to pull that fix into oCIS.Related Issue
Motivation and Context
Space managers are expected to be able to manage all shares within their space, regardless of who created them. Without this fix, only the original sharer could remove a share, which blocked normal space management workflows and surfaced as an opaque server error with no actionable log output.
How Has This Been Tested?
DELETE /drives/{driveId}/items/{itemId}/permissions/{permissionId}) — succeedsUnshareallowing removal by a manager withRemoveGrantand rejecting removal without it; fulljsoncs3package test suite passesScreenshots (if appropriate):
Types of changes
Checklist: