add CString support and optimise string allocations #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
force-pushed
the
add-cstring-support
branch
from
dde0442 to
0093188
Compare
ahl
reviewed
Nov 4, 2025
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
We'll take the C-string change; I don't think we're interested in the rest.
Comment on lines
+85
to
+86
|
|
||
| /// Avoid expensive string allocation with cstring support |
Collaborator
There was a problem hiding this comment.
Native C strings are also supported and don't require any additional allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487.
Please review each commit separately.