Skip to content

fix: compare manifest digests correctly in update check #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablopunk merged 1 commit into from
Apr 23, 2026
Merged

fix: compare manifest digests correctly in update check #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/actions/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ async function fetchLatestTag(token: string): Promise<string> {
if (!response.ok) return "latest";

const data = (await response.json()) as { tags?: string[] };
const tags = data.tags?.filter((t) => t !== "latest") ?? [];
// Only consider date-prefixed tags (YYYY-MM-DD-sha) to avoid raw git SHAs
const dateTagPattern = /^\d{4}-\d{2}-\d{2}-[a-f0-9]+$/;
const tags = data.tags?.filter((t) => dateTagPattern.test(t)) ?? [];

tags.sort((a, b) => b.localeCompare(a));
return tags[0] ?? "latest";
Expand All @@ -97,19 +99,26 @@ async function fetchLatestTag(token: string): Promise<string> {
}

async function getLocalImageDigest(): Promise<string | null> {
const containerName = await getContainerName();

// Inspect the image directly for its RepoDigests, which contains the
// manifest digest (matches what GHCR returns). The container's .Image
// field is the image config blob digest, which is different.
const result = await spawnCommand(
"docker",
["inspect", "--format", "{{.Image}}", containerName],
[
"inspect",
"--format",
"{{if .RepoDigests}}{{index .RepoDigests 0}}{{end}}",
`${IMAGE_NAME}:latest`,
],
{ timeout: 10000 },
);

if (!result.success || !result.stdout.trim()) {
return null;
}

return result.stdout.trim();
const match = result.stdout.trim().match(/@(sha256:[a-f0-9]+)/);
return match?.[1] ?? null;
}

function isCacheValid(entry: CacheEntry | undefined): boolean {
Expand Down
Loading