Skip to content

Comments

Setting task_accepted_time before serialization#2963

Merged
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:set_accepted_time
Jan 28, 2026
Merged

Setting task_accepted_time before serialization#2963
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:set_accepted_time

Conversation

@jpodivin
Copy link
Contributor

If we settask_accepted_time on the Event object before it proceeds to serialization, the value will correctly propagate to the database, and copr_build_finished_time should start getting reported again.

Since this code runs in a loop, and new times are getting appended, the last element of the list is used to set the value.

@centosinfra-prod-github-app
Copy link
Contributor

@jpodivin jpodivin requested a review from a team as a code owner January 23, 2026 15:48
@centosinfra-prod-github-app
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question, overall this approach LGTM, thanks!

@centosinfra-prod-github-app
Copy link
Contributor

@jpodivin jpodivin force-pushed the set_accepted_time branch 2 times, most recently from b7638f6 to 5630c78 Compare January 28, 2026 15:38
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@centosinfra-prod-github-app
Copy link
Contributor

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@lbarcziova lbarcziova added the mergeit Merge via Zuul label Jan 28, 2026
@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app
Copy link
Contributor

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit 508ef42 into packit:main Jan 28, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

Development

Successfully merging this pull request may close these issues.

2 participants