Merged
Conversation
34511a2 to
458aa86
Compare
458aa86 to
f76e282
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds support for two additional angular momentum coupling schemes (JJ and FJ) to the rydstate library, expanding beyond the existing LS coupling for alkaline earth atoms. The PR introduces new Rydberg state classes and corresponding basis classes for these coupling schemes, along with tests to verify transformations between different coupling representations.
Changes:
- Added RydbergStateSQDTAlkalineFJ and BasisSQDTAlkalineFJ classes for FJ coupling scheme
- Added BasisSQDTAlkalineJJ class for JJ coupling scheme (state class already existed)
- Refactored the nu calculation in RydbergStateSQDTAlkalineJJ to use a more concise list comprehension
- Added tests for basis transformations between LS, JJ, and FJ coupling schemes
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rydstate/rydberg/rydberg_sqdt.py | Adds RydbergStateSQDTAlkalineFJ class for FJ coupling and refactors RydbergStateSQDTAlkalineJJ.nu calculation; adds AngularKetFJ import |
| src/rydstate/rydberg/init.py | Exports new RydbergStateSQDTAlkalineFJ class |
| src/rydstate/basis/basis_sqdt.py | Adds BasisSQDTAlkalineJJ and BasisSQDTAlkalineFJ classes for generating bases in JJ and FJ coupling schemes |
| src/rydstate/basis/init.py | Exports new BasisSQDTAlkalineJJ and BasisSQDTAlkalineFJ classes |
| src/rydstate/init.py | Exports new coupling scheme classes at the top level |
| tests/test_basis.py | Adds test coverage for transformations between LS, JJ, and FJ coupling schemes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge after #17