Better error message on when the dataframe is empty for margins=True
#63133
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
reviewed
Nov 18, 2025
pandas/core/reshape/pivot.py
Outdated
|
|
||
| table_index = table.index | ||
| table_columns = table.columns | ||
| last_ind_or_col = table.iloc[-1, :].name |
Contributor
There was a problem hiding this comment.
Thanks for improving the error message.
I suggest leaving the error type IndexError as it is and re-raising with a different error message.
We can put this line table.iloc[-1, :].name, where we get the problem with indexing, in a try block and then re-raise:
except IndexError as err:
raise IndexError("Can't get margins since the result dataframe is empty") from err
Contributor
There was a problem hiding this comment.
@show981111, could you please add a test for the new error message?
Author
There was a problem hiding this comment.
@natmokval Thank you for the feedback! I updated my code.
rhshadrach
reviewed
Nov 25, 2025
| last_ind_or_col = table.iloc[-1, :].name | ||
| except IndexError as err: | ||
| raise IndexError( | ||
| "Can't get margins since the result dataframe is empty" |
Member
There was a problem hiding this comment.
It's not clear to me that this is an improvement in the error message. For example with the OP of the linked issue, isn't a natural question a user would have is "Why is the result DataFrame empty?"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue #60768
In
crosstabfunction, if the result dataframe is empty andmargins=True, then we getindex-out-of-boundssince the dataframe is empty. Instead of this, we can throw an error message indicating the result dataframe is empty so that the user can have a better idea.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.