Accept only one block in validate_block when upgrading a runtime
#10280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the validation is running the entire time using the same validation code, we can not accept any other blocks after a runtime upgrade was applied.
Member
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
eskimor
approved these changes
Nov 10, 2025
Member
|
I am assuming the collators already won't produce a multi block collation in that case? |
sandreim
approved these changes
Nov 11, 2025
tdimitrov
reviewed
Nov 11, 2025
skunert
approved these changes
Nov 11, 2025
| .output() | ||
| .expect("Runs the test"); | ||
|
|
||
| assert!(dbg!(String::from_utf8(output.stderr).unwrap()) |
Contributor
There was a problem hiding this comment.
Suggested change
| assert!(dbg!(String::from_utf8(output.stderr).unwrap()) | |
| assert!(String::from_utf8(output.stderr).unwrap() |
Comment on lines
742
to
743
| // assert!(dbg!(String::from_utf8(output.stderr).unwrap()) | ||
| // .contains("only one block per PoV is allowed")); |
Contributor
There was a problem hiding this comment.
Suggested change
| // assert!(dbg!(String::from_utf8(output.stderr).unwrap()) | |
| // .contains("only one block per PoV is allowed")); |
lexnv
approved these changes
Nov 11, 2025
…ly-one-block-per-pov' into bkchr-validation-only-one-block-per-pov
Member
Author
Yes |
bkchr
added
A4-backport-stable2506
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10280-to-stable2506
git worktree add --checkout .worktree/backport-10280-to-stable2506 backport-10280-to-stable2506
cd .worktree/backport-10280-to-stable2506
git reset --hard HEAD^
git cherry-pick -x 4e1d96383b2ae73de8e66ac9f8c8b8580ac9af80
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10280-to-stable2509
git worktree add --checkout .worktree/backport-10280-to-stable2509 backport-10280-to-stable2509
cd .worktree/backport-10280-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 4e1d96383b2ae73de8e66ac9f8c8b8580ac9af80
git push --force-with-lease |
EgorPopelyaev
added a commit
that referenced
this pull request
Nov 12, 2025
Backport #10280 into `stable2509` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Egor_P <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the validation is running the entire time using the same validation code, we can not accept any other blocks after a runtime upgrade was applied.