Cleanup HRMP channels that were force removed from RC state #10324
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
| ingress_channels: &[(ParaId, cumulus_primitives_core::AbridgedHrmpChannel)], | ||
| mqc_heads: &mut BTreeMap<ParaId, MessageQueueChain>, | ||
| ) { | ||
| // Complexity is O(N * lg N) but could be optimized for O(N) |
There was a problem hiding this comment.
Could you expand on how this could be done ?
There was a problem hiding this comment.
The Mqc Heads and ingress channels are both sorted. So instead of always calling binary search, you can keep an index and increment it. Although just writing this, I think the increment would possibly need to happen multiple times (loop).
Not sure if its worth it in practice, hence why i used the trivial approach here.
There was a problem hiding this comment.
I meant if you can write this in the comment :D
It sounds easy to implement. But anyway, yes, probably it won't bring a very big performance benefit so we can also leave it as it is for the moment.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Reported here https://hackmd.io/@JjziWrpMQ2OeBtz99n7JXg/ByqF7Av0ge. Change: